Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove map JS #3363

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Remove map JS #3363

merged 1 commit into from
Jun 26, 2023

Conversation

bensteinberg
Copy link
Contributor

This is a follow-up to #3362.

@bensteinberg bensteinberg requested a review from a team as a code owner June 26, 2023 14:30
@bensteinberg bensteinberg requested review from matteocargnelutti and removed request for a team June 26, 2023 14:30
@rebeccacremona rebeccacremona requested review from rebeccacremona and removed request for matteocargnelutti June 26, 2023 14:31
Copy link
Contributor

@rebeccacremona rebeccacremona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think probably this will, on merge, cause another commit of built assets, with an updated webpack-stats.json

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3363 (a16b0d9) into develop (5c85683) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3363   +/-   ##
========================================
  Coverage    69.79%   69.79%           
========================================
  Files           50       50           
  Lines         6945     6945           
========================================
  Hits          4847     4847           
  Misses        2098     2098           

@bensteinberg bensteinberg merged commit 184760e into harvard-lil:develop Jun 26, 2023
@rebeccacremona
Copy link
Contributor

rebeccacremona commented Jun 26, 2023

My above prediction was, of course, wrong: since we DID remove the entrypoint from webpack config in the first PR, the change to the stats file subsequent to that PR was sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants