-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon buttons #3589
Add icon buttons #3589
Conversation
return ["download-alt", "plus", "edit", "trash", "chevron-down", "chevron-up"].includes(value); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't include "search" as one of the icon options here because it differs in more than a couple of ways in use from these other icons — it's a smaller size, etc.
It should be easy to add it (and any others) in if we decide to reuse the IconButton
component within the search functionality on the page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3589 +/- ##
========================================
Coverage 69.03% 69.03%
========================================
Files 48 48
Lines 6978 6978
========================================
Hits 4817 4817
Misses 2161 2161 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to abstract this into a component!
What this does
IconButton
for use with many of the standalone icon buttons throughout Perma:c-button--icon
to style them.Notes
A small handful of the icons used on the Perma Dashboard are from Font Awesome. Others don't appear to be — for example, the Perma dashboard licenses Font Awesome 3.0.2, which includes a much chunkier chevron style than the one featured throughout the dashboard.
This component intends to make it easy to use:
Linear Issue
Satisfies LIL-2312
Screenshot
How to test
vue-dashboard
anddeveloper-playground
Django flagsconsole.log
the name of each button.