-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SectionHeading and PermaLinkDetails components #3591
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3591 +/- ##
========================================
Coverage 69.03% 69.03%
========================================
Files 48 48
Lines 6978 6978
========================================
Hits 4817 4817
Misses 2161 2161 ☔ View full report in Codecov by Sentry. |
<svg v-if="isChevron" class="c-button__chevron" aria-hidden="true" width="14" height="7" viewBox="0 0 14 7" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
<path v-if="props.icon === 'chevron-down'" d="M6.88136 7L14 1.58065L12.5763 0L6.88136 4.26591L1.42373 0L0 1.58065L6.88136 7Z" fill="#2E76EE"/> | ||
<path v-if="props.icon === 'chevron-up'" d="M6.88136 0L14 5.41935L12.5763 7L6.88136 2.73409L1.42373 7L0 5.41935L6.88136 0Z" fill="#2E76EE"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially exported this svg as a 18x9 shape to match the rendered browser size of each chevron image in the legacy dashboard. On closer look, the legacy png included additional whitespace around the chevrons.
To better match this, and future proof the way we might make use of the chevrons in the future, I slightly resized the svg itself and added the necessary margin with a css class.
(If we ever needed additional variants of chevrons in the future, we could always create a component for this and have it accept "size", "direction", and "color" props)
<SectionHeading name="Another Journal Links" icon="organization"> | ||
<template #iconButton> | ||
<IconButton | ||
icon="download-alt" | ||
name="Export Links" | ||
:handleClick="() => {console.log('Export Links');}" | ||
|
||
/> | ||
</template> | ||
</SectionHeading> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this does
PermaLinkDetails
andSectionHeading
components.IconButton
developer playground examples inCreateLink
with new examples nested within the new UIIconButton
styles and chevron paths to better match legacy dashboard UIUpdateGUID
fromCaptureError
now that it isn't needed (for now — the component will still exist for future reference)Screenshot
Linear Issue
Satisfies LIL-2313. Required for further work on the Batch Capture history UI.
How to Test
vue-dashboard
anddeveloper-playground
flags, either via query parameter or via the django admin.https://perma.test:8000/manage/create?dwft_DJANGO-FLAG=1