-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update batch capture functions, add composable to fetch batch history #3592
Update batch capture functions, add composable to fetch batch history #3592
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3592 +/- ##
========================================
Coverage 69.03% 69.03%
========================================
Files 48 48
Lines 6978 6978
========================================
Hits 4817 4817
Misses 2161 2161 ☔ View full report in Codecov by Sentry. |
70f6253
to
c9501a0
Compare
Looks good! I noticed a couple of things that were implemented via another PR I think. So feel free to look at them now or create a new ticket. Or just ignore if we aren't working on these yet :) The first one is when I initiate a batch capture, the progress modal shrinks to a very small size creating a scroll bar. I think we should tweak its sizing so everything is visible. And two, we should write the first sentence as |
Great observations! I'll merge this work in now and think that would be great follow-up work for the team to tackle in the future. |
Summary
This update refactors some previous component-scoped functions into composables (the Vue equivalent of React hooks) for reusability and adds a new composable for fetching a user's batch capture history.
Additional Notes
handleBatchDetailsFetch
andhandleBatchFormatting
. These have been renamed following the normal style for Vue composables, which are typically namedUse....
useBatchHistoryFetch
to fetch a user's batch historyLinkBatchHistory
component with minimal developer-only UI for testing out fetch functionalityRight now, this code merely displays the batch history when a user requests it by toggling a button. It does not automatically update the list of timestamps. In the future, this could become more reactive by moving the
batchCaptureId
out ofCreateLinkBatch
and into the global store inglobalStore.js
— then writing awatch
function to watch for changes to the batch capture id, and re-fetching an updated list of batch history info.For example,
Screenshots
Linear issue
Satisfies Linear issue 2316
How to test
vue-dashboard
anddeveloper-playground
Django flags