Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #3598

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

bensteinberg
Copy link
Contributor

In order to update urllib3, I had to update boto3 and botocore, as well as s3transfer:

https://urllib3.readthedocs.io/en/latest/changelog.html

https://github.com/boto/boto3/blob/develop/CHANGELOG.rst

https://github.com/boto/botocore/blob/develop/CHANGELOG.rst

Although the s3transfer README says

If you are planning to use this code in production, make sure to lock to a minor version as interfaces may break from minor version to minor version.

the changelog looks ok:

https://github.com/boto/s3transfer/blob/develop/CHANGELOG.rst

@bensteinberg bensteinberg requested a review from a team as a code owner September 5, 2024 13:39
@bensteinberg bensteinberg requested review from matteocargnelutti and rebeccacremona and removed request for a team and matteocargnelutti September 5, 2024 13:39
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (b70124e) to head (bde0aa3).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3598   +/-   ##
========================================
  Coverage    68.84%   68.84%           
========================================
  Files           48       48           
  Lines         7004     7004           
========================================
  Hits          4822     4822           
  Misses        2182     2182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rebeccacremona rebeccacremona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bensteinberg bensteinberg merged commit a333147 into harvard-lil:develop Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants