Fix bookmarklet #3604
Merged
Fix bookmarklet #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcushman
requested review from
rebeccacremona
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3604 +/- ##
===========================================
+ Coverage 68.68% 68.72% +0.04%
===========================================
Files 48 48
Lines 7063 7063
===========================================
+ Hits 4851 4854 +3
+ Misses 2212 2209 -3 ☔ View full report in Codecov by Sentry. |
jcushman
force-pushed
the
fix-bookmarklet
branch
from
7e50c49
to
2dad048
Compare
|
Added a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should include ?url= in the integration tests, but I didn't yet. :) LMK if you want to do that now or hold off since tests are being refactored.