Fix minute calculation for a running timer #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operly shows as :59 until hour is increased by one
|
Could we please add a test to cover this scenario? Thanks! |
|
Added the tests! |
braddunbar
approved these changes
Jun 23, 2023
pusewicz
approved these changes
Jun 26, 2023
|
@KaylaKremer Thank you! |
evanwalsh
approved these changes
Jun 26, 2023
| const minutes = Math.round(total) % 60 | ||
| let minutes = total % 60 | ||
| if (minutes >= 59.5 && minutes < 60) { | ||
| minutes = Math.floor(minutes) |
There was a problem hiding this comment.
FWIW, we could just hardcode 59 here since it's a known value.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to an issue brought up on our mobile repo.
With a running timer, when the time changes from
1:59to2:00for example, the time briefly displays at1:00instead of as2:00until another minute goes by, reverting back to the correct display time of2:01.This is due to the use of
Math.roundwhich causes the minutes to display as:00a bit too soon before the hour calculation increases by 1 since it will round up when the remainder value is 59.5 or greater.I added an
ifconditional to instead useMath.floorwhen the remainder value is between 59.5 and 60 to keep the value displaying as:59until the hour value increases by 1.