Skip to content

Add ru-text to plugins.json registry#12

Closed
talkstream wants to merge 1 commit into
hashgraph-online:mainfrom
talkstream:add-ru-text-plugins-json
Closed

Add ru-text to plugins.json registry#12
talkstream wants to merge 1 commit into
hashgraph-online:mainfrom
talkstream:add-ru-text-plugins-json

Conversation

@talkstream

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #11 — adds the machine-readable plugins.json registry entry for ru-text as recommended by @gemini-code-assist code review.

  • Adds entry in alphabetical order
  • Increments total to 21
  • Updates last_updated to 2026-03-31

Follow-up to PR hashgraph-online#11 — adds the machine-readable registry entry
for the HOL Plugin Registry as recommended by code review.
@kilo-code-bot

kilo-code-bot Bot commented Mar 30, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The PR correctly adds the ru-text plugin entry to the registry:

  • Entry inserted in proper alphabetical order (between PapersFlow and Yandex Direct)
  • All required fields present with correct structure
  • total incremented from 20 → 21 (matches actual count)
  • last_updated updated to 2026-03-31
  • install_url follows the established pattern
  • Valid JSON structure
Files Reviewed (1 file)
  • plugins.json - 0 issues

Reviewed by mimo-v2-pro-20260318 · 81,184 tokens

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request manually updates plugins.json to add the 'ru-text' plugin and increment the total count. However, the reviewer pointed out that plugins.json is a generated file and should not be modified manually; instead, the new plugin should be added to README.md and the generation script should be run to ensure consistency and prevent changes from being overwritten.

Comment thread plugins.json
Comment on lines +5 to +6
"last_updated": "2026-03-31",
"total": 21,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

It appears that plugins.json is a generated file, as indicated by the existence of scripts/generate_plugins_json.py. Manually updating this file is discouraged because your changes might be overwritten the next time the script is run. Furthermore, the website is built from README.md (via build.js), so a manual update here won't be reflected on the site.

Please ensure ru-text is added to README.md and then run the generation script to update the registry. This also ensures that metadata like total and last_updated are calculated consistently and that formatting (such as the use of literal characters vs. the escape sequence \u2014 for the em dash) matches the script's output (which uses ensure_ascii=False).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant