Add ru-text to plugins.json registry#12
Conversation
Follow-up to PR hashgraph-online#11 — adds the machine-readable registry entry for the HOL Plugin Registry as recommended by code review.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The PR correctly adds the
Files Reviewed (1 file)
Reviewed by mimo-v2-pro-20260318 · 81,184 tokens |
There was a problem hiding this comment.
Code Review
This pull request manually updates plugins.json to add the 'ru-text' plugin and increment the total count. However, the reviewer pointed out that plugins.json is a generated file and should not be modified manually; instead, the new plugin should be added to README.md and the generation script should be run to ensure consistency and prevent changes from being overwritten.
| "last_updated": "2026-03-31", | ||
| "total": 21, |
There was a problem hiding this comment.
It appears that plugins.json is a generated file, as indicated by the existence of scripts/generate_plugins_json.py. Manually updating this file is discouraged because your changes might be overwritten the next time the script is run. Furthermore, the website is built from README.md (via build.js), so a manual update here won't be reflected on the site.
Please ensure ru-text is added to README.md and then run the generation script to update the registry. This also ensures that metadata like total and last_updated are calculated consistently and that formatting (such as the use of literal characters vs. the escape sequence \u2014 for the em dash) matches the script's output (which uses ensure_ascii=False).
Summary
Follow-up to #11 — adds the machine-readable
plugins.jsonregistry entry for ru-text as recommended by @gemini-code-assist code review.totalto 21last_updatedto 2026-03-31