Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update helm publish registry to ghcr.io #361

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Nov 22, 2024

Description:

  • updated chart name to hedera-block-node-chart, in order to differentiate it from the image name hedera-block-node.
  • Changed the workflow that publishes the helm chart to use ghcr.io instead of a gh-pages branch.

Related issue(s):

Fixes #256

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 changed the title updated chart name to hedera-block-node-chart, in order to differenti… feat: update helm publish method Nov 22, 2024
@AlfredoG87 AlfredoG87 changed the title feat: update helm publish method feat: update helm publish registry Nov 22, 2024
@AlfredoG87 AlfredoG87 changed the title feat: update helm publish registry build: update helm publish registry Nov 22, 2024
@AlfredoG87 AlfredoG87 self-assigned this Nov 22, 2024
@AlfredoG87 AlfredoG87 added Release Issues tied to release management functions Block Node Issues/PR related to the Block Node. labels Nov 22, 2024
@AlfredoG87 AlfredoG87 added this to the 0.3.0 milestone Nov 22, 2024
@AlfredoG87
Copy link
Contributor Author

Waiting for this ticket to be resolved before being able to finish this ticket:
https://swirldslabs.atlassian.net/servicedesk/customer/portal/4/ITSD-133

@AlfredoG87 AlfredoG87 force-pushed the helm-publish-update branch 3 times, most recently from 9ad9c2b to 9794e44 Compare November 27, 2024 18:11
@AlfredoG87 AlfredoG87 marked this pull request as ready for review November 27, 2024 20:10
@AlfredoG87 AlfredoG87 requested review from a team as code owners November 27, 2024 20:10
…ate it from the image name hedera-block-node.

Changed the workflow that publishes the helm chart to use ghcr.io instead of a gh-pages branch.

Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 changed the title build: update helm publish registry build: update helm publish registry to ghcr.io Nov 27, 2024
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

georgi-l95
georgi-l95 previously approved these changes Nov 27, 2024
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small typos and a future suggestion.

.github/workflows/release-push-image.yaml Show resolved Hide resolved
charts/hedera-block-node/README.md Outdated Show resolved Hide resolved
charts/hedera-block-node/README.md Outdated Show resolved Hide resolved
charts/hedera-block-node/README.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (c0ee61f) to head (68f6100).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #361   +/-   ##
=========================================
  Coverage     97.77%   97.77%           
  Complexity      343      343           
=========================================
  Files            70       70           
  Lines          1256     1256           
  Branches         88       88           
=========================================
  Hits           1228     1228           
  Misses           19       19           
  Partials          9        9           

Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. Release Issues tied to release management functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Publish of Helm Charts out of GH Pages into JFrog or GHCR
6 participants