-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update helm publish registry to ghcr.io
#361
base: main
Are you sure you want to change the base?
Conversation
Waiting for this ticket to be resolved before being able to finish this ticket: |
9ad9c2b
to
9794e44
Compare
3269ad4
to
ea97c4a
Compare
…ate it from the image name hedera-block-node. Changed the workflow that publishes the helm chart to use ghcr.io instead of a gh-pages branch. Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
ea97c4a
to
8e44323
Compare
ghcr.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small typos and a future suggestion.
Signed-off-by: Alfredo Gutierrez <[email protected]>
881bf60
Signed-off-by: Alfredo Gutierrez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=========================================
Coverage 97.77% 97.77%
Complexity 343 343
=========================================
Files 70 70
Lines 1256 1256
Branches 88 88
=========================================
Hits 1228 1228
Misses 19 19
Partials 9 9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Description:
Related issue(s):
Fixes #256
Notes for reviewer:
Checklist