Daily rewards for active nodes #1064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Neeharika-Sompalli
requested review from
rbair23,
netopyr,
tinker-michaelj and
Mark-Swirlds
rbair23
reviewed
Oct 17, 2024
rbair23
reviewed
Oct 17, 2024
rbair23
reviewed
Oct 17, 2024
Neeharika-Sompalli
force-pushed
the
hip-0000-daily-node-rewards
branch
from
1a2f249
to
ca7ed2c
Compare
netopyr
reviewed
Oct 18, 2024
Neeharika-Sompalli
force-pushed
the
hip-0000-daily-node-rewards
branch
from
e098b2e
to
b9e961a
Compare
jsync-swirlds
previously approved these changes
Oct 18, 2024
netopyr
reviewed
Oct 21, 2024
netopyr
previously approved these changes
Oct 21, 2024
Neeharika-Sompalli
dismissed stale reviews from netopyr and jsync-swirlds
via
fafb83f
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Neeharika-Sompalli
force-pushed
the
hip-0000-daily-node-rewards
branch
from
8303a47
to
72146fd
Compare
tinker-michaelj
approved these changes
Nov 11, 2024
netopyr
reviewed
Nov 12, 2024
|
|
||
| - As a node operator, I expect to receive at least a minimum node reward when the node is active for at least | ||
| `nodes.activeRoundsPercent` rounds | ||
| - As a node operator, I do not expect to receive any node rewards when the node is not active for at least |
There was a problem hiding this comment.
I understand this is following the usual pattern for use cases, but I find it weird nevertheless. How about something like:
"As a user of the network, I expect that non-active nodes do not receive any node rewards..."
There was a problem hiding this comment.
As a user of the network
Do you mean the node operator Michael?
There was a problem hiding this comment.
No, I meant any regular user. It sounds weird for me to have a use case saying that somebody does not expect a certain behavior. However, as a regular user, I expect that the money I spend is only used for active nodes.
It's not important, though. It is clear what the expected behavior is.
There was a problem hiding this comment.
It might be worthwhile to have both.
The current node operator use case, and another with text very similar to what @netopyr suggested.
It's good to be clear about expectations for both node operator and network user.
There was a problem hiding this comment.
Ah makes sense. Thanks @netopyr . Added another use case
HIP/hip-1064.md
Outdated
|
|
||
| option java_package = "com.hederahashgraph.api.proto.java"; | ||
| // <<<pbj.java_package = "com.hedera.hapi.node.state.token">>> This comment is special code for setting PBJ Compiler java package | ||
| option java_multiple_files = true; |
There was a problem hiding this comment.
We should omit the header.
There was a problem hiding this comment.
Fixed. Thanks!
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a HIP for proposing daily rewards for active nodes