HIP-991 update according to latest discussion #1079
Conversation
…fee instead Signed-off-by: Michael Heinrichs <[email protected]>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HIP/hip-991.md
Outdated
|
|
||
| ### User Flows and Interaction | ||
|
|
||
| * Users will specify the fee settings during the topic creation process through a simple interface in their Hedera client (refer to the creation of token custom fees/fixed fee for reference). | ||
| * Before submitting a message to a topic through an application or wallet interface, users must set an allowance and a maximum fee per message. | ||
| * When submitting a message to a topic with custom fees through an application or wallet interface, users must set the maximum fee for the message. |
There was a problem hiding this comment.
to accommodate the requirement of accepting all fees, should we add a line that is something like:
- Users submitting messages can add a flag to accept all custom fees from a topic id
| @@ -232,6 +215,20 @@ message ConsensusCustomFeeList { | |||
| } | |||
| ``` | |||
|
|
|||
| #### ConsensusSubmitMessageTransactionBody | |||
|
|
|||
| The `ConsensusSubmitMessageTransactionBody` message is updated to include the optional `max_custom_fees` property for specifying the maximum fee that the user is willing to pay for the message. | |||
There was a problem hiding this comment.
Do we need to call out that there's a method to set accepts all fees in this section?
There was a problem hiding this comment.
Added the flag accept_all_fees
There was a problem hiding this comment.
It seems that the user must set either a max_custom_fees or set the accept_all_custom_fees to true. We can add a validation to throw an error if accept_all_custom_fees=false and max_custom_fees is not set.
There was a problem hiding this comment.
I don't think this is needed. If a topic has custom fees and neither max_custom_fees nor accept_all_custom_fees are set, the message will fail anyway because the fees cannot be paid.
Signed-off-by: Michael Heinrichs <[email protected]>
netopyr
requested review from
ty-swirldslabs,
Neurone,
jasperpotts and
rbair23
and removed request for
ty-swirldslabs
Signed-off-by: Michael Heinrichs <[email protected]>
HIP/hip-991.md
Outdated
| @@ -123,7 +108,7 @@ We propose adding a fixed fee mechanism to the Hedera Consensus Service (HCS) fo | |||
|
|
|||
| ##### Handling Duplicates | |||
|
|
|||
| If the FEKL list contains duplicate keys, the transaction will fail with an `FEKL_CONTAINS_DUPLICATED_KEYS` error. This ensures that duplicate entries are not silently ignored, preventing potential bugs or issues in the calling code. | |||
| If the FEKL list contains duplicate keys, the `ConsensusUpdateTopicTransaction` transaction will fail with an `FEKL_CONTAINS_DUPLICATED_KEYS` error. This ensures that duplicate entries are not silently ignored, preventing potential bugs or issues in the calling code. | |||
There was a problem hiding this comment.
How about the duplicates in the ConsensusCreateTopicTransaction? This validation should apply to both create and update.
There was a problem hiding this comment.
Right, thanks. I will update the sentence.
HIP/hip-991.md
Outdated
|
|
||
| ### User Flows and Interaction | ||
|
|
||
| * Users will specify the fee settings during the topic creation process through a simple interface in their Hedera client (refer to the creation of token custom fees/fixed fee for reference). | ||
| * Before submitting a message to a topic through an application or wallet interface, users must set an allowance and a maximum fee per message. | ||
| * When submitting a message to a topic with custom fees through an application or wallet interface, users must set the maximum fee for the message. |
There was a problem hiding this comment.
"users must set the maximum fee for the message" - when using the word must it seems that the field is required but the max_custom_fees is optional
There was a problem hiding this comment.
If the topic has custom fees and accept_all_custom_fees is false, a user must set max_custom_fees. In all other cases, the field is ignored and is therefore optional.
There was a problem hiding this comment.
Added a sentence for clarification.
|
There are a few more mentions of "allowances" in the Mirror Node and SDK Reference Implementation sections. You can remove those. |
Signed-off-by: Michael Heinrichs <[email protected]>
| @@ -123,7 +108,7 @@ We propose adding a fixed fee mechanism to the Hedera Consensus Service (HCS) fo | |||
|
|
|||
| ##### Handling Duplicates | |||
|
|
|||
| If the FEKL list contains duplicate keys, the transaction will fail with an `FEKL_CONTAINS_DUPLICATED_KEYS` error. This ensures that duplicate entries are not silently ignored, preventing potential bugs or issues in the calling code. | |||
| If the FEKL list contains duplicate keys, the `ConsensusCreateTopicTransaction`, respectively `ConsensusUpdateTopicTransaction`, will fail with a `FEKL_CONTAINS_DUPLICATED_KEYS` error. This ensures that duplicate entries are not silently ignored, preventing potential bugs or issues in the calling code. | |||
There was a problem hiding this comment.
The FEKL_CONTAINS_DUPLICATED_KEYS can be renamed to FEE_EXEMPT_KEY_LIST_CONTAINS_DUPLICATED_KEYS.
Description:
This PR modifies the HIP according to the latest discussion:
max_custom_feeinstead