-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero Cost EthereumTransaction on Success #1084
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
I think referring to success/failure can be misleading in the HIP's title and description. I suggest using something like well-formed, formally valid, etc.
I recommend dropping the success/failure wording and clearly stating the list of results for which the submitter will be charged $0.0001 (e.g., Any results not in the list above will be free for the submitter, whether it's an EVM error or not (e.g., |
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
Changes for clarity and list of examples
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Neurone I agree, the text has been updated, but I think it would benefit from being even more precise. |
- The `relay` is charged if the `evm tx` cannot be parsed or is otherwise malformed | ||
- The `relay` is charged if the `EOA` specified in the `evm tx` refers to a non-existent account | ||
- The `relay` is charged if the `evm tx` was not properly signed by the keys of the `EOA` | ||
- The `relay` is charged if the `EOA` has insufficient funds to pay the intrinsic gas fee | ||
- The `relay` is charged if the `nonce` check fails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed highlights a list of prechecks performed by the Relay to validate transactions and reject them if any conditions are met, ensuring they are not forwarded to the network unnecessarily, thus avoiding charges. Notably, the Hedera JSON-RPC Relay already handles and rejects these scenarios. However, there are additional prechecks currently performed by the Relay that are not mentioned here:
- Transaction type
- Gas price
- Gas limit
- Chain ID
- Value
- calldata size (not exceed 128KB maximum)
I recommend considering these prechecks and including them in this HIP for greater clarity and completeness.
Description:
On many EVM chains execution costs are fully captured in gas. Thus submitting transactions to execution nodes bears no
cost to the relay node. On Hedera it is necessary to charge a fee for
EthereumTransaction
HAPI submissions (just likeall other HAPI transactions).
This HIP suggests the network logic not charge successful
EthereumTransaction
submissions, but instead only charge theregular HAPI fee for badly formed transactions.
Related issue(s):
Fixes #1083
Notes for reviewer:
Checklist