Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for OPERATOR_KEY_FORMAT #2591

Merged
merged 5 commits into from
Jun 13, 2024
Merged

feat: Added support for OPERATOR_KEY_FORMAT #2591

merged 5 commits into from
Jun 13, 2024

Conversation

ebadiere
Copy link
Contributor

Adds support for OPERATOR_KEY_FORMAT

Related issue(s):

Fixes #2583

@ebadiere ebadiere requested review from AlfredoG87, lukelee-sl and a team as code owners June 11, 2024 22:05
@ebadiere ebadiere added the enhancement New feature or request label Jun 11, 2024
@ebadiere ebadiere added this to the 0.50.0 milestone Jun 11, 2024
@ebadiere ebadiere marked this pull request as draft June 11, 2024 22:06
@ebadiere ebadiere self-assigned this Jun 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

Acceptance Tests

  20 files  276 suites   30m 55s ⏱️
603 tests 595 ✔️ 3 💤 5 ❌
878 runs  867 ✔️ 5 💤 6 ❌

Results for commit 2b4aacf.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

Tests

    2 files  151 suites   14s ⏱️
844 tests 843 ✔️ 1 💤 0 ❌
856 runs  855 ✔️ 1 💤 0 ❌

Results for commit 2b4aacf.

♻️ This comment has been updated with latest results.

@ebadiere ebadiere marked this pull request as ready for review June 12, 2024 11:38
@ebadiere ebadiere requested a review from quiet-node June 12, 2024 15:37
AlfredoG87
AlfredoG87 previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

quiet-node
quiet-node requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just some queries and suggestions.

docs/configuration.md Show resolved Hide resolved
packages/relay/src/lib/services/hapiService/hapiService.ts Show resolved Hide resolved
packages/relay/tests/lib/sdkClient.spec.ts Outdated Show resolved Hide resolved
packages/relay/src/lib/services/hapiService/hapiService.ts Outdated Show resolved Hide resolved
@ebadiere @quiet-node
Update packages/relay/tests/lib/sdkClient.spec.ts
5dcd8f6 
Co-authored-by: Logan Nguyen <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>
AlfredoG87
AlfredoG87 previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebadiere
fix: Added tests.
2b4aacf 
Signed-off-by: ebadiere <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

quiet-node
quiet-node approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ebadiere ebadiere merged commit e1ab6bf into main Jun 13, 2024
35 checks passed
@ebadiere ebadiere deleted the 2583-improve-privateKey-import-from-environment-variable branch June 13, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quiet-node quiet-node quiet-node approved these changes

@AlfredoG87 AlfredoG87 AlfredoG87 left review comments

@lukelee-sl lukelee-sl Awaiting requested review from lukelee-sl

Assignees

@ebadiere ebadiere

Labels
enhancement New feature or request
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.50.0
Development

Successfully merging this pull request may close these issues.

Improve PrivateKey import from environment variable
3 participants
@ebadiere @quiet-node @AlfredoG87