Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds check for license header #3203

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

konstantinabl
Copy link
Collaborator

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

github-actions bot commented Nov 1, 2024

Test Results

 19 files   -  1  256 suites  +8   32m 17s ⏱️ +26s
608 tests  -  1  603 ✅ ± 0  4 💤 ±0  1 ❌  - 1 
662 runs   - 37  657 ✅  - 36  4 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit f604f05. ± Comparison against base commit 27a10dc.

This pull request removes 1 test.
"before all" hook in "@api-batch-2 RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before all" hook in "@api-batch-2 RPC Server Acceptance Tests"

♻️ This comment has been updated with latest results.

@quiet-node quiet-node added the internal For changes that affect the project's internal workings but not its outward-facing functionality. label Nov 6, 2024
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl force-pushed the 3192-chore-add-custom-rule-to-check-the-existence-of-license-header-in-each-file branch from 497d7a5 to dea510c Compare November 18, 2024 10:09
Copy link

sonarcloud bot commented Nov 18, 2024

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.91%. Comparing base (27a10dc) to head (f604f05).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
- Coverage   78.92%   76.91%   -2.01%     
==========================================
  Files          48       52       +4     
  Lines        3606     3786     +180     
  Branches      841      868      +27     
==========================================
+ Hits         2846     2912      +66     
- Misses        422      535     +113     
- Partials      338      339       +1     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 78.63% <ø> (ø)
ws-server 36.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: add custom rule to check the existence of license header in each file
2 participants