Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update workflow permissions for github token #3284

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

PavelSBorisov
Copy link
Member

@PavelSBorisov PavelSBorisov commented Nov 21, 2024

Description:
Workflow permissions should be set to

permissions:
  contents: read
  checks: write

Related issue(s):

Fixes #3275

Notes for reviewer:
N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@PavelSBorisov PavelSBorisov added this to the 0.61.0 milestone Nov 21, 2024
@PavelSBorisov PavelSBorisov requested review from AlfredoG87, Nana-EC and a team as code owners November 21, 2024 11:47
Copy link

github-actions bot commented Nov 21, 2024

Test Results

 19 files   -   6  239 suites   - 132   30m 0s ⏱️ - 5m 36s
609 tests  -  11  604 ✅ +  8  4 💤 ±0  1 ❌  - 19 
624 runs   - 344  619 ✅  - 321  4 💤  - 3  1 ❌  - 20 

For more details on these failures, see this check.

Results for commit d34b91a. ± Comparison against base commit e10ba94.

This pull request removes 12 and adds 1 tests. Note that renamed tests count towards both.
"after all" hook in "@web-socket-batch-1 eth_call" ‑ RPC Server Acceptance Tests Acceptance tests @web-socket-batch-1 eth_call "after all" hook in "@web-socket-batch-1 eth_call"
"before all" hook for "emits an approval event" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests ERC20 Contract should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender has enough allowance "before all" hook for "emits an approval event"
"before all" hook for "emits an approval event" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender has enough allowance "before all" hook for "emits an approval event"
"before all" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests ERC20 Contract should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance when the token owner has enough balance "before all" hook for "reverts"
"before all" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance when the token owner has enough balance "before all" hook for "reverts"
"before all" hook in "Debug API Test Suite" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite "before all" hook in "Debug API Test Suite"
"before each" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests ERC20 Contract should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance "before each" hook for "reverts"
"before each" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests ERC20 Contract should behave like erc20 transfer from when the token owner is not the zero address when the recipient is the zero address "before each" hook for "reverts"
"before each" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance "before each" hook for "reverts"
"before each" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is the zero address "before each" hook for "reverts"
…
"before all" hook in "@api-batch-2 RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before all" hook in "@api-batch-2 RPC Server Acceptance Tests"

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 21, 2024

Copy link

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@PavelSBorisov PavelSBorisov merged commit b55ca6b into main Nov 22, 2024
47 of 51 checks passed
@PavelSBorisov PavelSBorisov deleted the 3275-update-workflow-permissions-for-github-token branch November 22, 2024 08:17
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (e10ba94) to head (d34b91a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3284   +/-   ##
=======================================
  Coverage   77.89%   77.89%           
=======================================
  Files          66       66           
  Lines        4470     4470           
  Branches     1003     1003           
=======================================
  Hits         3482     3482           
  Misses        613      613           
  Partials      375      375           
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 78.64% <ø> (ø)
server 83.28% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Update workflow permissions for github token
4 participants