Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace release notes generator action with one maintained by stepsecurity #3291

Conversation

PavelSBorisov
Copy link
Member

Description:
The release-automation.yml workflow uses a release notes generator action that has an equivalent maintained by StepSecurity.
This PR replaces it with the StepSecurity variant.

Related issue(s):

Fixes #3267

Notes for reviewer:
N/A
Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link

github-actions bot commented Nov 22, 2024

Test Results

 19 files   -   3  256 suites   - 39   31m 58s ⏱️ - 4m 18s
608 tests  -   1  603 ✅ + 20  4 💤 ±0  1 ❌  - 21 
662 runs   - 188  657 ✅  - 166  4 💤 ±0  1 ❌  - 22 

For more details on these failures, see this check.

Results for commit 0792258. ± Comparison against base commit b55ca6b.

This pull request removes 1 test.
"before all" hook for "@release should deploy a contract" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Acceptance Tests eth_getLogs "before all" hook for "@release should deploy a contract"

♻️ This comment has been updated with latest results.

Copy link

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrewb1269hg
Copy link

@Nana-EC the codecov for this repo is below 80% which is causing failure of the codecov check. How would you like to resolve this issue?

@rbarkerSL for SA.

@Nana-EC
Copy link
Collaborator

Nana-EC commented Nov 22, 2024

@Nana-EC the codecov for this repo is below 80% which is causing failure of the codecov check. How would you like to resolve this issue?

@rbarkerSL for SA.

In a non-blocking fashion.
We'll open a ticket to get the codecov back up. Thanks

@Nana-EC Nana-EC merged commit 7accf1f into main Nov 23, 2024
46 of 49 checks passed
@Nana-EC Nana-EC deleted the 3267-update-release-notes-generator-action-to-step-security-version branch November 23, 2024 03:39
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (b55ca6b) to head (0792258).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3291      +/-   ##
==========================================
- Coverage   78.88%   77.89%   -0.99%     
==========================================
  Files          48       66      +18     
  Lines        3608     4470     +862     
  Branches      841     1003     +162     
==========================================
+ Hits         2846     3482     +636     
- Misses        423      613     +190     
- Partials      339      375      +36     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 78.64% <ø> (+0.05%) ⬆️
server 83.28% <ø> (?)
ws-server 36.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release-notes-generator-action to step-security version
4 participants