-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replaced eth-address with evm-address in code #3293
chore: replaced eth-address with evm-address in code #3293
Conversation
@simzzz also the commit doesn't seem to be verified. They should all be signed with your GPG key. Here’s a helpful resource: Signing Commits. |
Signed-off-by: Simeon Nakov <[email protected]>
823ccc6
to
e6aafe1
Compare
Quality Gate passedIssues Measures |
My bad, it's signed now and I've added the comment @quiet-node |
Nice thanks! Okay the team and I will get to the review process soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work and TYVM for the effort! 🚀 🚀 🚀
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
===========================================
- Coverage 78.88% 46.99% -31.89%
===========================================
Files 48 65 +17
Lines 3608 4424 +816
Branches 841 1014 +173
===========================================
- Hits 2846 2079 -767
- Misses 423 1963 +1540
- Partials 339 382 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
In this PR, all mentions of EthAddress have been renamed to EvmAddress for better clarity, as suggested in this comment
Related issue(s):
Fixes #3125
Notes for reviewer:
Checklist