Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replaced eth-address with evm-address in code #3293

Merged

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Nov 22, 2024

Description:
In this PR, all mentions of EthAddress have been renamed to EvmAddress for better clarity, as suggested in this comment

Related issue(s):

Fixes #3125

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node
Copy link
Member

@simzzz Heyy thanks for the contribution! Appreciate the time and effort! Could you kindly make a comment on the issue #3125 so I can assign you to the ticket?

@quiet-node quiet-node added the internal For changes that affect the project's internal workings but not its outward-facing functionality. label Nov 22, 2024
@quiet-node quiet-node added this to the 0.61.0 milestone Nov 22, 2024
@quiet-node quiet-node added good first issue Good for newcomers good first issue candidate Issues that can become a good first issue but need more description/context. labels Nov 22, 2024
@quiet-node
Copy link
Member

@simzzz also the commit doesn't seem to be verified. They should all be signed with your GPG key. Here’s a helpful resource: Signing Commits.

@simzzz simzzz force-pushed the 3125-swap-eth-address-with-evm-address branch from 823ccc6 to e6aafe1 Compare November 22, 2024 16:01
Copy link

sonarcloud bot commented Nov 22, 2024

@simzzz
Copy link
Contributor Author

simzzz commented Nov 22, 2024

My bad, it's signed now and I've added the comment @quiet-node

@quiet-node
Copy link
Member

quiet-node commented Nov 22, 2024

My bad, it's signed now and I've added the comment @quiet-node

Nice thanks! Okay the team and I will get to the review process soon!

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work and TYVM for the effort! 🚀 🚀 🚀

@quiet-node quiet-node merged commit e46298e into hashgraph:main Nov 22, 2024
38 of 40 checks passed
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 39 lines in your changes missing coverage. Please review.

Project coverage is 46.99%. Comparing base (b55ca6b) to head (e6aafe1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ay/src/lib/config/hbarSpendingPlanConfigService.ts 28.57% 20 Missing ⚠️
...barLimiter/evmAddressHbarSpendingPlanRepository.ts 45.00% 10 Missing and 1 partial ⚠️
...s/relay/src/lib/services/hbarLimitService/index.ts 60.00% 4 Missing and 4 partials ⚠️

❗ There is a different number of reports uploaded between BASE (b55ca6b) and HEAD (e6aafe1). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b55ca6b) HEAD (e6aafe1)
config-service 1 0
relay 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3293       +/-   ##
===========================================
- Coverage   78.88%   46.99%   -31.89%     
===========================================
  Files          48       65       +17     
  Lines        3608     4424      +816     
  Branches      841     1014      +173     
===========================================
- Hits         2846     2079      -767     
- Misses        423     1963     +1540     
- Partials      339      382       +43     
Flag Coverage Δ
config-service ?
relay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...entities/hbarLimiter/evmAddressHbarSpendingPlan.ts 100.00% <100.00%> (ø)
...kages/relay/src/lib/db/types/hbarLimiter/errors.ts 66.66% <100.00%> (-33.34%) ⬇️
packages/relay/src/lib/relay.ts 82.85% <100.00%> (-5.72%) ⬇️
packages/relay/src/lib/types/spendingPlanConfig.ts 50.00% <ø> (-50.00%) ⬇️
...s/relay/src/lib/services/hbarLimitService/index.ts 67.15% <60.00%> (-16.79%) ⬇️
...barLimiter/evmAddressHbarSpendingPlanRepository.ts 34.88% <45.00%> (ø)
...ay/src/lib/config/hbarSpendingPlanConfigService.ts 25.86% <28.57%> (-62.94%) ⬇️

... and 50 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue candidate Issues that can become a good first issue but need more description/context. good first issue Good for newcomers internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap eth address for evm address everywhere in the hbar limiter code
3 participants