Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move current node account id logging logic into sdk client #3297

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

natanasow
Copy link
Collaborator

Description:

Follow-up on #3292

Related issue(s):

Fixes #3296

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@natanasow natanasow self-assigned this Nov 25, 2024
@natanasow natanasow added the enhancement New feature or request label Nov 25, 2024
@natanasow natanasow added this to the 0.62.0 milestone Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Test Results

 18 files   -   9  235 suites   - 187   32m 34s ⏱️ - 44m 59s
606 tests  -   6  602 ✅ + 13  4 💤 ±0  0 ❌  - 19 
622 runs   - 465  618 ✅  - 437  4 💤  - 5  0 ❌  - 23 

Results for commit ac4ae12. ± Comparison against base commit d7f1bdc.

This pull request removes 6 tests.
"before all" hook for "emits an approval event" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender has enough allowance "before all" hook for "emits an approval event"
"before all" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance when the token owner has enough balance "before all" hook for "reverts"
"before all" hook in "Debug API Test Suite" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite "before all" hook in "Debug API Test Suite"
"before each" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance "before each" hook for "reverts"
"before each" hook for "should execute "eth_getStorageAt" request to get current state changes" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get current state changes"
"before each" hook: reducing balance for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests ERC20 Contract should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance when the token owner does not have enough balance "before each" hook: reducing balance for "reverts"

♻️ This comment has been updated with latest results.

@natanasow natanasow marked this pull request as ready for review November 25, 2024 08:54
@natanasow natanasow requested review from AlfredoG87, lukelee-sl and a team as code owners November 25, 2024 08:54
@natanasow natanasow requested a review from Nana-EC November 25, 2024 10:51
Copy link

sonarcloud bot commented Nov 27, 2024

@natanasow natanasow requested a review from quiet-node November 27, 2024 13:03
@Nana-EC Nana-EC merged commit b021318 into main Nov 27, 2024
45 of 46 checks passed
@Nana-EC Nana-EC deleted the 3296-add-exposed-node-account-id-into-SDKError branch November 27, 2024 23:31
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.55%. Comparing base (d7f1bdc) to head (ac4ae12).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/relay/src/lib/clients/sdkClient.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3297      +/-   ##
==========================================
+ Coverage   77.92%   81.55%   +3.63%     
==========================================
  Files          66       69       +3     
  Lines        4476     4636     +160     
  Branches     1004     1041      +37     
==========================================
+ Hits         3488     3781     +293     
+ Misses        615      500     -115     
+ Partials      373      355      -18     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 78.72% <20.00%> (+0.05%) ⬆️
server 83.28% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/errors/SDKClientError.ts 79.16% <100.00%> (+0.90%) ⬆️
packages/relay/src/lib/eth.ts 77.94% <100.00%> (+6.65%) ⬆️
packages/relay/src/lib/clients/sdkClient.ts 66.37% <0.00%> (+11.29%) ⬆️

... and 23 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exposed node account id into SDKError
3 participants