Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reserved_staking_rewards field to NodeStakeUpdateTransactionBody #300

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Contributor

Description:

Neeharika-Sompalli and others added 28 commits April 12, 2023 18:15
* Add HCS state proto

Signed-off-by: Michael Tinker <[email protected]>

* Add running hash, delete EntityNumber

Signed-off-by: Michael Tinker <[email protected]>

* add account and token

* add account and token

* add token

* add tokenRelation

* add some javadocs

* add some javadocs

* address review comments

* fix missing import

* address comments

* address review comments

* Update services/state/token/account.proto

Co-authored-by: Richard Bair <[email protected]>

* Update services/state/token/account.proto

Co-authored-by: Richard Bair <[email protected]>

* address some review comments

* move back under services

* change package name

* some docs and revert java package name

* revert docs

* add javadocs

* add javadocs

* re-order the first 16

---------

Signed-off-by: Michael Tinker <[email protected]>
Co-authored-by: Michael Tinker <[email protected]>
Co-authored-by: Richard Bair <[email protected]>
* 265 - file proto

Signed-off-by: Lev Povolotsky <[email protected]>

* 265 - packaging

Signed-off-by: Lev Povolotsky <[email protected]>

* 265 - comments

Signed-off-by: Lev Povolotsky <[email protected]>

---------

Signed-off-by: Lev Povolotsky <[email protected]>
* change allowances

* change allowances

* change allowances

* change allowances

* change allowances

* change allowances
* 265 - file proto

Signed-off-by: Lev Povolotsky <[email protected]>

* 265 - packaging

Signed-off-by: Lev Povolotsky <[email protected]>

* 265 - comments

Signed-off-by: Lev Povolotsky <[email protected]>

* 265 - comments fix

Signed-off-by: Lev Povolotsky <[email protected]>

---------

Signed-off-by: Lev Povolotsky <[email protected]>
* add missing fields and change allowance names

* change to bits

* address review comments

* address review comments

* address review comments
* Add bytecode and storage slot representations

Signed-off-by: Michael Tinker <[email protected]>

* Add Nft type

Signed-off-by: Michael Tinker <[email protected]>

* Add EntityNumber

Signed-off-by: Michael Tinker <[email protected]>

* Use bytes instead of Int256Value

Signed-off-by: Michael Tinker <[email protected]>

* Fix typo

Signed-off-by: Michael Tinker <[email protected]>

* Remove superfluous Int256Value type

Signed-off-by: Michael Tinker <[email protected]>

* Rename Id -> UniqueTokenId

Signed-off-by: Michael Tinker <[email protected]>

* Don't store code_hash, can be cached on load

Signed-off-by: Michael Tinker <[email protected]>

---------

Signed-off-by: Michael Tinker <[email protected]>
* Added state for blocks and running hashes

Signed-off-by: jasperpotts <[email protected]>

---------

Signed-off-by: jasperpotts <[email protected]>
Co-authored-by: jasperpotts <[email protected]>
* new schedule proto

Signed-off-by: Lev Povolotsky <[email protected]>

* addresspe comments

Signed-off-by: Lev Povolotsky <[email protected]>

* address comments

Signed-off-by: Lev Povolotsky <[email protected]>

---------

Signed-off-by: Lev Povolotsky <[email protected]>
Original commit of this file uses package com.hedera.hapi.node.state.file
The correct package is com.hedera.hapi.node.state.schedule.

Signed-off-by: Joseph Sinclair <[email protected]>
…ication (#285)

* Initial commit

* Replace instead of deprecate previous field

* change topic number to topicID (#286)

Signed-off-by: Lev Povolotsky <[email protected]>

* Initial commit

* Replace instead of deprecate previous field

---------

Signed-off-by: Lev Povolotsky <[email protected]>
Co-authored-by: Lev Povolotsky <[email protected]>
* Changed body_bytes to original_create_transaction
   * Changed type to TransactionBody
 * Updated comments to clarify several items and correct language

Signed-off-by: Joseph Sinclair <[email protected]>
* Change nft owner and spender identifier from long to AccountID

* Import basic_types.proto for AccountID

Signed-off-by: Kim Rader <[email protected]>

---------

Signed-off-by: Kim Rader <[email protected]>
…at rely on it to use AccountID and TokenID (#290)

* Updated common.proto to use use AccountID and TokenID instead of long

* Updated token.proto to use use AccountID and TokenID instead of long

* Updated token_relation.proto to use use AccountID and TokenID instead of long
…roto (#293)

changed auto_renew_account_number to auto_renew_account_id
* add fields from MerkleNetworkContext

* add fields from MerkleNetworkContext

* doc update

* doc update

* doc update

* doc update
* Updated last_block_number in BlockInfo to match all others

* Added staked_id, removed staked_number.

* updated number
Updated Schedule state protobuf to add a wait_for_expiry flag.
 * This protobuf is not yet used, so the fields were renumbered for efficient representation.
 * This is in support of resolving Issue #5518

Signed-off-by: Joseph Sinclair <[email protected]>
Update account.proto to use IDs instead of longs

Signed-off-by: Kim Rader <[email protected]>
…299)

* Added primitive.proto which includes ProtoLong, ProtoInteger, ProtoBoolen, ProtoString, and ProtoBytes.
* Added ScheduleList message to schedule.proto

Signed-off-by: Joseph Sinclair <[email protected]>
@tinker-michaelj tinker-michaelj requested review from a team as code owners August 10, 2023 17:00
@tinker-michaelj tinker-michaelj requested review from iwsimon and jascks and removed request for a team August 10, 2023 17:00
xin-hedera
xin-hedera previously approved these changes Aug 10, 2023
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

steven-sheehy
steven-sheehy previously approved these changes Aug 10, 2023
Base automatically changed from add-pbj-types-for-state to main March 7, 2024 17:19
@nathanklick nathanklick dismissed stale reviews from steven-sheehy, Neeharika-Sompalli, and xin-hedera March 7, 2024 17:19

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants