-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reserved_staking_rewards
field to NodeStakeUpdateTransactionBody
#300
Open
tinker-michaelj
wants to merge
28
commits into
main
Choose a base branch
from
07946-update-on-reserved-rewards
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add HCS state proto Signed-off-by: Michael Tinker <[email protected]> * Add running hash, delete EntityNumber Signed-off-by: Michael Tinker <[email protected]> * add account and token * add account and token * add token * add tokenRelation * add some javadocs * add some javadocs * address review comments * fix missing import * address comments * address review comments * Update services/state/token/account.proto Co-authored-by: Richard Bair <[email protected]> * Update services/state/token/account.proto Co-authored-by: Richard Bair <[email protected]> * address some review comments * move back under services * change package name * some docs and revert java package name * revert docs * add javadocs * add javadocs * re-order the first 16 --------- Signed-off-by: Michael Tinker <[email protected]> Co-authored-by: Michael Tinker <[email protected]> Co-authored-by: Richard Bair <[email protected]>
* 265 - file proto Signed-off-by: Lev Povolotsky <[email protected]> * 265 - packaging Signed-off-by: Lev Povolotsky <[email protected]> * 265 - comments Signed-off-by: Lev Povolotsky <[email protected]> --------- Signed-off-by: Lev Povolotsky <[email protected]>
* change allowances * change allowances * change allowances * change allowances * change allowances * change allowances
* 265 - file proto Signed-off-by: Lev Povolotsky <[email protected]> * 265 - packaging Signed-off-by: Lev Povolotsky <[email protected]> * 265 - comments Signed-off-by: Lev Povolotsky <[email protected]> * 265 - comments fix Signed-off-by: Lev Povolotsky <[email protected]> --------- Signed-off-by: Lev Povolotsky <[email protected]>
* add missing fields and change allowance names * change to bits * address review comments * address review comments * address review comments
* Add bytecode and storage slot representations Signed-off-by: Michael Tinker <[email protected]> * Add Nft type Signed-off-by: Michael Tinker <[email protected]> * Add EntityNumber Signed-off-by: Michael Tinker <[email protected]> * Use bytes instead of Int256Value Signed-off-by: Michael Tinker <[email protected]> * Fix typo Signed-off-by: Michael Tinker <[email protected]> * Remove superfluous Int256Value type Signed-off-by: Michael Tinker <[email protected]> * Rename Id -> UniqueTokenId Signed-off-by: Michael Tinker <[email protected]> * Don't store code_hash, can be cached on load Signed-off-by: Michael Tinker <[email protected]> --------- Signed-off-by: Michael Tinker <[email protected]>
* Added state for blocks and running hashes Signed-off-by: jasperpotts <[email protected]> --------- Signed-off-by: jasperpotts <[email protected]> Co-authored-by: jasperpotts <[email protected]>
add staking node info
* new schedule proto Signed-off-by: Lev Povolotsky <[email protected]> * addresspe comments Signed-off-by: Lev Povolotsky <[email protected]> * address comments Signed-off-by: Lev Povolotsky <[email protected]> --------- Signed-off-by: Lev Povolotsky <[email protected]>
Signed-off-by: Joseph Sinclair <[email protected]>
Signed-off-by: Joseph Sinclair <[email protected]>
Original commit of this file uses package com.hedera.hapi.node.state.file The correct package is com.hedera.hapi.node.state.schedule. Signed-off-by: Joseph Sinclair <[email protected]>
Signed-off-by: Lev Povolotsky <[email protected]>
…ication (#285) * Initial commit * Replace instead of deprecate previous field * change topic number to topicID (#286) Signed-off-by: Lev Povolotsky <[email protected]> * Initial commit * Replace instead of deprecate previous field --------- Signed-off-by: Lev Povolotsky <[email protected]> Co-authored-by: Lev Povolotsky <[email protected]>
* Changed body_bytes to original_create_transaction * Changed type to TransactionBody * Updated comments to clarify several items and correct language Signed-off-by: Joseph Sinclair <[email protected]>
* Change nft owner and spender identifier from long to AccountID * Import basic_types.proto for AccountID Signed-off-by: Kim Rader <[email protected]> --------- Signed-off-by: Kim Rader <[email protected]>
…at rely on it to use AccountID and TokenID (#290) * Updated common.proto to use use AccountID and TokenID instead of long * Updated token.proto to use use AccountID and TokenID instead of long * Updated token_relation.proto to use use AccountID and TokenID instead of long
Signed-off-by: Kim Rader <[email protected]>
…roto (#293) changed auto_renew_account_number to auto_renew_account_id
* add fields from MerkleNetworkContext * add fields from MerkleNetworkContext * doc update * doc update * doc update * doc update
* Updated last_block_number in BlockInfo to match all others * Added staked_id, removed staked_number. * updated number
Updated Schedule state protobuf to add a wait_for_expiry flag. * This protobuf is not yet used, so the fields were renumbered for efficient representation. * This is in support of resolving Issue #5518 Signed-off-by: Joseph Sinclair <[email protected]>
Update account.proto to use IDs instead of longs Signed-off-by: Kim Rader <[email protected]>
…299) * Added primitive.proto which includes ProtoLong, ProtoInteger, ProtoBoolen, ProtoString, and ProtoBytes. * Added ScheduleList message to schedule.proto Signed-off-by: Joseph Sinclair <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
tinker-michaelj
requested review from
iwsimon and
jascks
and removed request for
a team
August 10, 2023 17:00
xin-hedera
previously approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Neeharika-Sompalli
previously approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
steven-sheehy
previously approved these changes
Aug 10, 2023
nathanklick
dismissed stale reviews from steven-sheehy, Neeharika-Sompalli, and xin-hedera
March 7, 2024 17:19
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
0.0.800
balance reserved to pay pending rewards at the close of the just-ending staking period.0.0.800
balance in end-of-periodNodeStakeUpdateTransaction
hedera-services#7946