Conversation
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
|
|
||
| - name: Update hedera-services branch | ||
| run: | | ||
| sed -i 's/branch = "main"/branch = "${{ env.branch }}"/' hedera-services/hapi/build.gradle.kts |
There was a problem hiding this comment.
This might have issues with the occasional branch modification. Here's a possible fix:
| sed -i 's/branch = "main"/branch = "${{ env.branch }}"/' hedera-services/hapi/build.gradle.kts | |
| sed -i 's/branch = "[a-zA-Z\-\/0-9]+"/branch = "${{ env.branch }}"/' hedera-services/hapi/build.gradle.kts |
There was a problem hiding this comment.
Agreed. We might not have main as branch name always in services.
| sed -i 's/branch = "main"/branch = "${{ env.branch }}"/' hedera-services/hapi/build.gradle.kts | ||
|
|
||
| - name: Run Gradle assemble | ||
| run: ./gradlew assemble |
There was a problem hiding this comment.
This may be OK, but we might need to add the cgroup controls Nathan worked out for services to make sure the compile doesn't starve out the github agent on the runner.
Something to watch for.
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
| - name: Update hedera-services branch | ||
| run: | | ||
| sed -i 's/branch = "main"/branch = "${{ env.branch }}"/' hedera-services/hapi/build.gradle.kts | ||
| sed -i.bak "s/branch = \".*\"/branch = \"${GITHUB_HEAD_REF}\"/" hedera-services/hapi/build.gradle.kts |
There was a problem hiding this comment.
Something worth noting:
Sed is greedy by default, so this might match a lot more than we want, basically it will extend as far as it can without crossing to a new line. That shouldn't be an issue, unless someone puts a comment at end of line with a " in it, in which case this may break (that's why I restricted the match set in my suggestion).
Neeharika-Sompalli
left a comment
Neeharika-Sompalli
left a comment
There was a problem hiding this comment.
LGTM! Thanks @tinker-michaelj
|
@tinker-michaelj Is this PR still active and relevant? |
3 participants
Description:
main.