-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add needed TransactionOutput
fields
#415
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Tinker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure we actually need the new outputs.
We deliberately do not include values that are present in some other block item in outputs, so created ID values (which must be present in the state changes) or messages added to state as part of a transaction (i.e. PendingAirdrop messages) are not included in transaction outputs, for example.
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Michael Tinker <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Michael Tinker <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Michael Tinker <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Michael Tinker <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Michael Tinker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small question remains.
* that is identical to the one that was requested.<br/> | ||
* For any other status, this value SHALL NOT be set. | ||
*/ | ||
proto.ScheduleID schedule_id = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be renamed to duplicate_schedule_id
?
Also, if we only set this for duplicate schedules, we may need to remove the first specification sentence in the document comment above.
Description:
TransactionOutput
fields forSCHEDULE_CREATE
,TOKEN_AIRDROP
, andETHEREUM_TRANSACTION
that are necessary to recover the full record stream from the block stream.