chore: add needed TransactionOutput fields#415
Open
tinker-michaelj wants to merge 9 commits intomainfrom
Open
Conversation
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Member
jsync-swirlds
left a comment
jsync-swirlds
left a comment
There was a problem hiding this comment.
I am not sure we actually need the new outputs.
We deliberately do not include values that are present in some other block item in outputs, so created ID values (which must be present in the state changes) or messages added to state as part of a transaction (i.e. PendingAirdrop messages) are not included in transaction outputs, for example.
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Member
jsync-swirlds
left a comment
jsync-swirlds
left a comment
There was a problem hiding this comment.
Looks good, one small question remains.
| * that is identical to the one that was requested.<br/> | ||
| * For any other status, this value SHALL NOT be set. | ||
| */ | ||
| proto.ScheduleID schedule_id = 1; |
Member
There was a problem hiding this comment.
Should this be renamed to duplicate_schedule_id?
Also, if we only set this for duplicate schedules, we may need to remove the first specification sentence in the document comment above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
TransactionOutputfields forSCHEDULE_CREATE,TOKEN_AIRDROP, andETHEREUM_TRANSACTIONthat are necessary to recover the full record stream from the block stream.