test: add shouldBytesNoSetters tests

Signed-off-by: Ivan Ivanov <[email protected]>
hashgraph · Dec 2, 2024 · aa6f575 · aa6f575
1 parent dff3bef
commit aa6f575
Show file tree

Hide file tree

Showing 51 changed files with 358 additions and 19 deletions.
diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountAllowanceApproveTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountAllowanceApproveTransactionTest.java
@@ -103,6 +103,14 @@ void propertiesTest() {
         assertThat(tx.getTokenNftApprovals()).isNotEmpty();
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new AccountAllowanceApproveTransaction();
+        var tx2 = AccountAllowanceApproveTransaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
+
     @Test
     void fromScheduledTransaction() {
         var transactionBody = SchedulableTransactionBody.newBuilder()

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountAllowanceDeleteTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountAllowanceDeleteTransactionTest.java
@@ -71,7 +71,14 @@ void shouldSerialize() {
     @Test
     void shouldBytes() throws Exception {
         var tx = spawnTestTransaction();
-        var tx2 = AccountAllowanceApproveTransaction.fromBytes(tx.toBytes());
+        var tx2 = AccountAllowanceDeleteTransaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new AccountAllowanceDeleteTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountCreateTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountCreateTransactionTest.java
@@ -107,6 +107,14 @@ void shouldBytes2() throws Exception {
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new AccountCreateTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
+
     @Test
     void propertiesTest() {
         var tx = spawnTestTransaction();

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountDeleteTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountDeleteTransactionTest.java
@@ -72,6 +72,13 @@ void shouldBytes() throws Exception {
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new AccountDeleteTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void fromScheduledTransaction() {
         var transactionBody = SchedulableTransactionBody.newBuilder()

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountUpdateTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/AccountUpdateTransactionTest.java
@@ -96,6 +96,13 @@ void shouldBytes() throws Exception {
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new AccountUpdateTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void shouldSerialize2() {
         SnapshotMatcher.expect(spawnTestTransaction2().toString()).toMatchSnapshot();

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/ContractCreateTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/ContractCreateTransactionTest.java
@@ -63,6 +63,13 @@ void shouldSerialize2() {
         ).toMatchSnapshot();
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new ContractCreateTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     private ContractCreateTransaction spawnTestTransaction() {
         return new ContractCreateTransaction()
             .setNodeAccountIds(Arrays.asList(AccountId.fromString("0.0.5005"), AccountId.fromString("0.0.5006")))

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/ContractDeleteTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/ContractDeleteTransactionTest.java
@@ -73,6 +73,13 @@ void shouldBytes() throws Exception {
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new ContractDeleteTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void fromScheduledTransaction() {
         var transactionBody = SchedulableTransactionBody.newBuilder()

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/ContractExecuteTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/ContractExecuteTransactionTest.java
@@ -55,6 +55,13 @@ void shouldSerialize() {
         ).toMatchSnapshot();
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new ContractExecuteTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     private ContractExecuteTransaction spawnTestTransaction() {
         return new ContractExecuteTransaction()
             .setNodeAccountIds(Arrays.asList(AccountId.fromString("0.0.5005"), AccountId.fromString("0.0.5006")))

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/ContractUpdateTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/ContractUpdateTransactionTest.java
@@ -62,6 +62,13 @@ void shouldSerialize2() {
         ).toMatchSnapshot();
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new ContractUpdateTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     private ContractUpdateTransaction spawnTestTransaction() {
         return new ContractUpdateTransaction()
             .setNodeAccountIds(Arrays.asList(AccountId.fromString("0.0.5005"), AccountId.fromString("0.0.5006")))

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/CryptoTransferTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/CryptoTransferTransactionTest.java
@@ -57,6 +57,13 @@ void shouldSerialize() {
         ).toMatchSnapshot();
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new TransferTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     private TransferTransaction spawnTestTransaction() {
         return new TransferTransaction()
             .setNodeAccountIds(Arrays.asList(AccountId.fromString("0.0.5005"), AccountId.fromString("0.0.5006")))

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/EthereumTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/EthereumTransactionTest.java
@@ -39,6 +39,13 @@ EthereumTransaction spawnTestTransaction() {
             .sign(unusedPrivateKey);
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new EthereumTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void shouldSerialize() {
         SnapshotMatcher.expect(spawnTestTransaction()

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/FileAppendTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/FileAppendTransactionTest.java
@@ -117,6 +117,13 @@ private FileAppendTransaction spawnTestTransaction(List<AccountId> accountIds) {
             .sign(unusedPrivateKey);
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new FileAppendTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void shouldSerializeBigContents() {
         var nodeAccountIds = new ArrayList<AccountId>();

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/FileCreateTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/FileCreateTransactionTest.java
@@ -54,6 +54,13 @@ void shouldSerialize() {
         ).toMatchSnapshot();
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new FileCreateTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     private FileCreateTransaction spawnTestTransaction() {
         return new FileCreateTransaction()
             .setNodeAccountIds(Arrays.asList(AccountId.fromString("0.0.5005"), AccountId.fromString("0.0.5006")))

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/FileDeleteTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/FileDeleteTransactionTest.java
@@ -54,6 +54,13 @@ void shouldSerialize() {
         ).toMatchSnapshot();
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new FileDeleteTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     private FileDeleteTransaction spawnTestTransaction() {
         return new FileDeleteTransaction()
             .setNodeAccountIds(Arrays.asList(AccountId.fromString("0.0.5005"), AccountId.fromString("0.0.5006")))

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/FileUpdateTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/FileUpdateTransactionTest.java
@@ -75,6 +75,15 @@ void shouldBytes() throws Exception {
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
+
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new FileUpdateTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
+
     @Test
     void fromScheduledTransaction() {
         var transactionBody = SchedulableTransactionBody.newBuilder()

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/FreezeTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/FreezeTransactionTest.java
@@ -77,6 +77,13 @@ void shouldBytes() throws Exception {
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new FreezeTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void fromScheduledTransaction() {
         var transactionBody = SchedulableTransactionBody.newBuilder()

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/LiveHashAddTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/LiveHashAddTransactionTest.java
@@ -48,6 +48,13 @@ private LiveHashAddTransaction spawnTestTransaction() {
             .sign(privateKey);
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new LiveHashAddTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void shouldBytes() throws Exception {
         var tx = spawnTestTransaction();

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/LiveHashDeleteTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/LiveHashDeleteTransactionTest.java
@@ -48,7 +48,14 @@ private LiveHashDeleteTransaction spawnTestTransaction() {
     @Test
     void shouldBytes() throws Exception {
         var tx = spawnTestTransaction();
-        var tx2 = LiveHashAddTransaction.fromBytes(tx.toBytes());
+        var tx2 = LiveHashDeleteTransaction.fromBytes(tx.toBytes());
         assertThat(tx2).hasToString(tx.toString());
     }
+
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new LiveHashDeleteTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
 }
diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/MessageSubmitTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/MessageSubmitTransactionTest.java
@@ -54,6 +54,13 @@ void shouldBytes() throws Exception {
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new TopicMessageSubmitTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void shouldSerialize() {
         SnapshotMatcher.expect(spawnTestTransaction()

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/NodeCreateTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/NodeCreateTransactionTest.java
@@ -122,14 +122,12 @@ void fromScheduledTransaction() {
         assertThat(tx).isInstanceOf(NodeCreateTransaction.class);
     }
 
+
     @Test
-    void testSerializeDeserialize() throws Exception {
-        var tx = new NodeCreateTransaction().setDescription(TEST_DESCRIPTION);
-        var tx2 = new NodeCreateTransaction().setDescription(TEST_DESCRIPTION);
-        var tx2Bytes = tx2.toBytes();
-        NodeCreateTransaction deserializedTx2 = (NodeCreateTransaction) Transaction.fromBytes(tx2Bytes);
-        assertThat(tx.getGossipCaCertificate()).isEqualTo(deserializedTx2.getGossipCaCertificate());
-        assertThat(tx.getGrpcCertificateHash()).isEqualTo(deserializedTx2.getGrpcCertificateHash());
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new NodeCreateTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
     @Test
@@ -142,7 +140,6 @@ void testSetNull()  {
             .setAdminKey(null);
     }
 
-
     @Test
     void constructNodeCreateTransactionFromTransactionBodyProtobuf() {
         var transactionBodyBuilder = NodeCreateTransactionBody.newBuilder();

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/NodeDeleteTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/NodeDeleteTransactionTest.java
@@ -74,6 +74,13 @@ void shouldBytes() throws Exception {
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new NodeDeleteTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void fromScheduledTransaction() {
         var transactionBody = SchedulableTransactionBody.newBuilder()

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/NodeUpdateTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/NodeUpdateTransactionTest.java
@@ -118,13 +118,10 @@ void shouldBytes() throws Exception {
     }
 
     @Test
-    void testNullOptionalValues() throws Exception {
+    void shouldBytesNoSetters() throws Exception {
         var tx = new NodeUpdateTransaction();
-        var tx2Bytes = tx.toBytes();
-        NodeUpdateTransaction deserializedTx = (NodeUpdateTransaction) Transaction.fromBytes(tx2Bytes);
-        assertThat(deserializedTx.getGossipCaCertificate()).isNull();
-        assertThat(deserializedTx.getGrpcCertificateHash()).isNull();
-        assertThat(deserializedTx.getDescription()).isNull();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
     @Test

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/ScheduleCreateTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/ScheduleCreateTransactionTest.java
@@ -75,4 +75,11 @@ void shouldBytes() throws Exception {
         var tx2 = ScheduleCreateTransaction.fromBytes(tx.toBytes());
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
+
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new ScheduleCreateTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
 }
diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/ScheduleDeleteTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/ScheduleDeleteTransactionTest.java
@@ -71,6 +71,13 @@ void shouldBytes() throws Exception {
         assertThat(tx2.toString()).isEqualTo(tx.toString());
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new ScheduleDeleteTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     @Test
     void fromScheduledTransaction() {
         var transactionBody = SchedulableTransactionBody.newBuilder()

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/ScheduleSignTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/ScheduleSignTransactionTest.java
@@ -52,6 +52,13 @@ void shouldSerialize() {
         ).toMatchSnapshot();
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new ScheduleSignTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     private ScheduleSignTransaction spawnTestTransaction() {
         return new ScheduleSignTransaction()
             .setNodeAccountIds(Arrays.asList(AccountId.fromString("0.0.5005"), AccountId.fromString("0.0.5006")))

diff --git a/sdk/src/test/java/com/hedera/hashgraph/sdk/SystemDeleteTransactionTest.java b/sdk/src/test/java/com/hedera/hashgraph/sdk/SystemDeleteTransactionTest.java
@@ -72,6 +72,13 @@ void shouldSerializeContract() {
         SnapshotMatcher.expect(spawnTestTransactionContract().toString()).toMatchSnapshot();
     }
 
+    @Test
+    void shouldBytesNoSetters() throws Exception {
+        var tx = new SystemDeleteTransaction();
+        var tx2 = Transaction.fromBytes(tx.toBytes());
+        assertThat(tx2.toString()).isEqualTo(tx.toString());
+    }
+
     private SystemDeleteTransaction spawnTestTransactionContract() {
         return new SystemDeleteTransaction().setNodeAccountIds(
                 Arrays.asList(AccountId.fromString("0.0.5005"), AccountId.fromString("0.0.5006")))