Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TCK): Implement tokenDelete #2088

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat(TCK): Implement tokenDelete #2088

merged 1 commit into from
Nov 20, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Nov 19, 2024

Description:

Implement tokenDelete for TCK

Related issue(s):

Fixes #2089

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov added the enhancement New feature or request label Nov 19, 2024
@0xivanov 0xivanov self-assigned this Nov 19, 2024
@0xivanov 0xivanov requested a review from a team as a code owner November 19, 2024 15:04
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.63%. Comparing base (b86ee46) to head (fcbb0e8).
Report is 160 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2088      +/-   ##
============================================
+ Coverage     82.20%   82.63%   +0.43%     
- Complexity     3588     3932     +344     
============================================
  Files           186      199      +13     
  Lines         11697    12729    +1032     
  Branches       1150     1253     +103     
============================================
+ Hits           9615    10519     +904     
- Misses         1604     1712     +108     
- Partials        478      498      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit 8c89cb3 into main Nov 20, 2024
13 checks passed
@0xivanov 0xivanov deleted the tck-token-delete branch November 20, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK: Implement tokenDelete
2 participants