Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OpenSSL for TLS #895

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Use OpenSSL for TLS #895

wants to merge 5 commits into from

Conversation

RickyLB
Copy link
Contributor

@RickyLB RickyLB commented Feb 17, 2025 •
edited
Loading

Signed-off-by: Ricky Saechao [email protected]

Description:

  • Upgrade Tonic crate (0.11.0 → 0.12.3)
  • Use OpenSSL for TLS (required for ldft transition)
  • Update copyright header date range
  • Fetch protobufs from Hiero consensus node

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@RickyLB RickyLB requested review from a team as code owners February 17, 2025 04:08
@RickyLB RickyLB force-pushed the chore/replace_tls branch 2 times, most recently from 60f9d8e to b0aeded Compare February 17, 2025 04:54
@RickyLB RickyLB requested review from a team as code owners February 17, 2025 04:54
@RickyLB RickyLB requested a review from rbarker-dev February 17, 2025 04:54
@RickyLB RickyLB force-pushed the chore/replace_tls branch 3 times, most recently from 39d91fc to 0c2bbab Compare February 17, 2025 05:31
Sheng-Long
Sheng-Long previously approved these changes Feb 18, 2025
View reviewed changes
rwalworth
rwalworth previously approved these changes Feb 18, 2025
View reviewed changes
Copy link

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RickyLB RickyLB dismissed stale reviews from Sheng-Long and rwalworth via 0db3206 February 19, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbarker-dev rbarker-dev rbarker-dev approved these changes

@Sheng-Long Sheng-Long Sheng-Long left review comments

@rwalworth rwalworth rwalworth left review comments

@matteriben matteriben Awaiting requested review from matteriben matteriben is a code owner automatically assigned from hashgraph/release-engineering

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RickyLB @Sheng-Long @rwalworth @rbarker-dev