Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add initial support for Comparable in protobuf-defined state types. #11229

Closed
wants to merge 1 commit into from
Closed

feat: Add initial support for Comparable in protobuf-defined state types. #11229

wants to merge 1 commit into from

Conversation

jsync-swirlds
Copy link
Member

@jsync-swirlds jsync-swirlds commented Jan 29, 2024 •
edited
Loading

  • Changed the protobufs branch to use the commit hash with updated proto definitions.
    • This is part of moving away from branches to commit hashes and tags for long-term stability.
  • Fixed "pretty print" test in smart contract impl that depends on internal data type names in PBJ.
  • Modified KeyComparator to make use of new compareTo methods and explicitly "normalize" results.

@jsync-swirlds jsync-swirlds force-pushed the add-comparable-from-pbj branch 3 times, most recently from 4dbcb2d to 279b5fb Compare January 30, 2024 18:32
@jsync-swirlds
feat: Add initial support for Comparable in protobuf-defined state ty…
4a71d3b 
…pes.

* Changed the protobufs branch to use the commit hash with updated proto definitions.
   * This is part of moving away from branches to commit hashes and tags for long-term stability.
* Fixed "pretty print" test in smart contract impl that depends on internal data type names in PBJ.
* Modified KeyComparator to make use of new compareTo methods and explicitly "normalize" results.
* Fixed new protobuf clone task to not prepend `origin` unnecessarily, preventing use of commit hash.

Signed-off-by: Joseph Sinclair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj Awaiting requested review from tinker-michaelj tinker-michaelj will be requested when the pull request is marked ready for review tinker-michaelj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jsync-swirlds