ci: Prevent certain checks from running on forked PRs #16047

andrewb1269hg · 2024-10-18T18:32:50Z

Description:
Add a check for a forked repo to any workflow file steps which use secrets.* token or default GITHUB_TOKEN.

Related Issue(s):
Fixes #16004

github-actions · 2024-10-18T18:40:34Z

Node: HAPI Test (Restart) Results

9 files 1 errors 8 suites 7m 50s ⏱️
7 tests 7 ✅ 0 💤 0 ❌
8 runs 8 ✅ 0 💤 0 ❌

For more details on these parsing errors, see this check.

Results for commit d62de25.

♻️ This comment has been updated with latest results.

codacy-production · 2024-10-18T18:42:01Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00% (target: -1.00%)	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`029a73f`)	97692	63846	65.35%
Head commit (`2128cab`)	97692 (+0)	63846 (+0)	65.35% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#16047)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2024-10-18T18:42:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.65%. Comparing base (029a73f) to head (2128cab).

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #16047   +/-   ##
==========================================
  Coverage      63.65%   63.65%           
  Complexity     20447    20447           
==========================================
  Files           2538     2538           
  Lines          94927    94927           
  Branches        9919     9919           
==========================================
  Hits           60424    60424           
  Misses         30891    30891           
  Partials        3612     3612

.github/workflows/node-flow-fsts-daily-interval-02.yaml

.github/workflows/node-flow-build-application.yaml

.github/workflows/flow-node-performance-tests.yaml

.github/workflows/node-flow-deploy-adhoc-artifact.yaml

.github/workflows/node-flow-deploy-preview.yaml

.github/workflows/node-flow-deploy-release-artifact.yaml

.github/workflows/node-flow-fsts-custom-regression.yaml

.github/workflows/flow-node-performance-tests.yaml

rbarkerSL · 2024-10-21T18:35:22Z

.github/workflows/flow-pull-request-formatting.yaml

@@ -51,6 +51,7 @@ jobs:
          egress-policy: audit

      - name: Check PR Title
+        if: ${{ !github.event.pull_request.base.repo.fork }}


We should check for the fork condition at the job level instead of at the individual step

This doesn't appear to have been updated. I'm moving it to the level under title-check step so it will skip on the whole job.

.github/workflows/node-flow-deploy-release-artifact.yaml

.github/workflows/node-flow-fsts-daily-interval-01.yaml

.github/workflows/node-flow-pull-request-checks.yaml

andrewb1269hg · 2024-10-23T15:42:17Z

Major updates:

Removed all workflow_dispatch checks.
Added checks to workflow_call files.
Reformat and standardize the order of if-check stanzas inside steps.

.github/workflows/flow-pull-request-formatting.yaml

.github/workflows/node-zxc-build-release-artifact.yaml

.github/workflows/node-zxc-compile-application-code.yaml

**Description**: Add a check to any workflow file steps which use secrets.* token or default GITHUB_TOKEN. **Related Issue(s)**: Fixes #16004 Signed-off-by: Andrew Brandt <[email protected]>

rbarkerSL

LGTM

andrewb1269hg linked an issue Oct 18, 2024 that may be closed by this pull request

Prevent certain checks from running on forked PRs #16004

Open

andrewb1269hg self-assigned this Oct 18, 2024

andrewb1269hg added this to the v0.56 milestone Oct 18, 2024

andrewb1269hg changed the title ~~ci: Add fork repo check in workflows~~ ci: Prevent certain checks from running on forked PRs Oct 18, 2024

andrewb1269hg marked this pull request as ready for review October 21, 2024 11:18

andrewb1269hg requested review from a team as code owners October 21, 2024 11:18

andrewb1269hg requested a review from rbarkerSL October 21, 2024 11:18

andrewb1269hg force-pushed the 16004-prevent-certain-checks-from-running-on-forked-prs branch 2 times, most recently from 2b822a9 to 3a70aef Compare October 21, 2024 11:37

nathanklick requested changes Oct 21, 2024

View reviewed changes

.github/workflows/node-flow-fsts-daily-interval-02.yaml Outdated Show resolved Hide resolved

nathanklick reviewed Oct 21, 2024

View reviewed changes

rbarkerSL requested changes Oct 21, 2024

View reviewed changes

rbarkerSL marked this pull request as draft October 21, 2024 22:25

andrewb1269hg force-pushed the 16004-prevent-certain-checks-from-running-on-forked-prs branch 2 times, most recently from ec1e411 to 9eab51e Compare October 22, 2024 19:28

andrewb1269hg marked this pull request as ready for review October 23, 2024 15:40

rbarkerSL previously approved these changes Oct 23, 2024

View reviewed changes

rbarkerSL self-requested a review October 29, 2024 14:06

andrewb1269hg dismissed rbarkerSL’s stale review via 72e158e October 29, 2024 14:13

rbarkerSL previously approved these changes Oct 29, 2024

View reviewed changes

nathanklick requested changes Nov 4, 2024

View reviewed changes

.github/workflows/flow-pull-request-formatting.yaml Show resolved Hide resolved

andrewb1269hg dismissed rbarkerSL’s stale review via c14b80e November 5, 2024 13:35

rbarkerSL requested review from nathanklick and rbarkerSL November 5, 2024 14:48

rbarkerSL previously approved these changes Nov 5, 2024

View reviewed changes

andrewb1269hg dismissed rbarkerSL’s stale review via 768919c November 26, 2024 12:56

rbarkerSL previously approved these changes Nov 26, 2024

View reviewed changes

nathanklick requested changes Nov 26, 2024

View reviewed changes

.github/workflows/node-zxc-build-release-artifact.yaml Outdated Show resolved Hide resolved

andrewb1269hg dismissed rbarkerSL’s stale review via 2ea5ec4 November 26, 2024 17:45

rbarkerSL previously approved these changes Nov 26, 2024

View reviewed changes

nathanklick requested changes Nov 26, 2024

View reviewed changes

andrewb1269hg dismissed rbarkerSL’s stale review via 1346368 November 26, 2024 18:38

andrewb1269hg force-pushed the 16004-prevent-certain-checks-from-running-on-forked-prs branch from 1346368 to 14e60c3 Compare December 2, 2024 21:34

andrewb1269hg requested a review from a team as a code owner December 2, 2024 21:34

andrewb1269hg requested a review from dalvizu December 2, 2024 21:34

ci: Add fork repo check in workflows

2128cab

**Description**: Add a check to any workflow file steps which use secrets.* token or default GITHUB_TOKEN. **Related Issue(s)**: Fixes #16004 Signed-off-by: Andrew Brandt <[email protected]>

andrewb1269hg force-pushed the 16004-prevent-certain-checks-from-running-on-forked-prs branch from 60e7d2d to 2128cab Compare December 2, 2024 21:58

rbarkerSL modified the milestones: v0.56, v0.58 Dec 3, 2024

rbarkerSL approved these changes Dec 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Prevent certain checks from running on forked PRs #16047

ci: Prevent certain checks from running on forked PRs #16047

andrewb1269hg commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

codacy-production bot commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

rbarkerSL Oct 21, 2024

andrewb1269hg Oct 22, 2024

andrewb1269hg Dec 2, 2024

andrewb1269hg commented Oct 23, 2024

rbarkerSL left a comment

ci: Prevent certain checks from running on forked PRs #16047

Are you sure you want to change the base?

ci: Prevent certain checks from running on forked PRs #16047

Conversation

andrewb1269hg commented Oct 18, 2024 • edited Loading

github-actions bot commented Oct 18, 2024 • edited Loading

Node: HAPI Test (Restart) Results

codacy-production bot commented Oct 18, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Oct 18, 2024 • edited Loading

Codecov Report

rbarkerSL Oct 21, 2024

Choose a reason for hiding this comment

andrewb1269hg Oct 22, 2024

Choose a reason for hiding this comment

andrewb1269hg Dec 2, 2024

Choose a reason for hiding this comment

andrewb1269hg commented Oct 23, 2024

rbarkerSL left a comment

Choose a reason for hiding this comment

andrewb1269hg commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

codacy-production bot commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading