Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 16657: State validation fails for round 191161423 on LSE #16757

Merged
merged 1 commit into from
Nov 23, 2024

fix: 16657: State validation fails for round 191161423 on LSE

75e2662
Select commit
Loading
Failed to load commit list.
Merged

fix: 16657: State validation fails for round 191161423 on LSE #16757

fix: 16657: State validation fails for round 191161423 on LSE
75e2662
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 22, 2024 in 1s

63.45% (-0.05%) compared to 82638c1

View this Pull Request on Codecov

63.45% (-0.05%) compared to 82638c1

Details

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.45%. Comparing base (82638c1) to head (75e2662).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...wirlds/virtualmap/internal/hash/VirtualHasher.java 66.66% 1 Missing and 1 partial ⚠️
...rtualmap/internal/merkle/AbstractHashListener.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16757      +/-   ##
=============================================
- Coverage      63.50%   63.45%   -0.05%     
- Complexity     20295    20316      +21     
=============================================
  Files           2544     2545       +1     
  Lines          94488    94604     +116     
  Branches        9868     9878      +10     
=============================================
+ Hits           60004    60033      +29     
- Misses         30873    30954      +81     
- Partials        3611     3617       +6
Files with missing lines Coverage Δ
...almap/internal/reconnect/ReconnectNodeRemover.java 93.54% <100.00%> (-0.21%) ⬇️
...rtualmap/internal/merkle/AbstractHashListener.java 84.37% <66.66%> (+1.29%) ⬆️
...wirlds/virtualmap/internal/hash/VirtualHasher.java 86.59% <66.66%> (-0.45%) ⬇️

... and 58 files with indirect coverage changes

Impacted file tree graph

---- 🚨 Try these New Features:
View more details on Codecov