Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app and services to stop querying the platform for the roster #16771

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

MiroslavGatsanoga
Copy link
Collaborator

@MiroslavGatsanoga MiroslavGatsanoga commented Nov 25, 2024

Description:

Remove Platform.getRoster() calls from Services code.

Related issue(s):

Fixes #16721

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.58 milestone Nov 25, 2024
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Nov 25, 2024
Copy link

codacy-production bot commented Nov 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 79.17%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b8f0637) 97548 63724 65.33%
Head commit (31b83d3) 97609 (+61) 63776 (+52) 65.34% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16771) 24 19 79.17%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.64%. Comparing base (b8f0637) to head (31b83d3).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...-app/src/main/java/com/hedera/node/app/Hedera.java 44.44% 4 Missing and 1 partial ⚠️
...rc/main/java/com/hedera/node/app/ServicesMain.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16771      +/-   ##
=============================================
+ Coverage      63.63%   63.64%   +0.01%     
- Complexity     20409    20434      +25     
=============================================
  Files           2537     2538       +1     
  Lines          94783    94859      +76     
  Branches        9907     9909       +2     
=============================================
+ Hits           60312    60377      +65     
- Misses         30869    30878       +9     
- Partials        3602     3604       +2     
Files with missing lines Coverage Δ
...a/com/hedera/node/app/platform/PlatformModule.java 100.00% <ø> (ø)
...edera/node/app/throttle/ThrottleServiceModule.java 100.00% <100.00%> (ø)
...n/java/com/hedera/node/app/tss/TssBaseService.java 40.00% <ø> (ø)
...va/com/hedera/node/app/tss/TssBaseServiceImpl.java 66.88% <ø> (ø)
...app/workflows/standalone/TransactionExecutors.java 92.59% <100.00%> (ø)
...rkflows/standalone/impl/StandaloneNetworkInfo.java 71.42% <100.00%> (+15.17%) ⬆️
...rc/main/java/com/hedera/node/app/ServicesMain.java 29.41% <0.00%> (-0.25%) ⬇️
...-app/src/main/java/com/hedera/node/app/Hedera.java 56.72% <44.44%> (-0.39%) ⬇️

... and 17 files with indirect coverage changes

Impacted file tree graph

@MiroslavGatsanoga MiroslavGatsanoga force-pushed the 16721-services-stop-querying-platform-for-roster branch from 0a177a5 to 20a5ea8 Compare November 25, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The app and services stop querying the platform for the address book or roster.
2 participants