Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deep VirtualMap key validation for reconnect tests #16824

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

thenswan
Copy link
Contributor

@thenswan thenswan commented Nov 27, 2024

Description:
This PR adds deep VirtualMap key validation for reconnect tests.

Related issue(s):
Fixes #16754

@thenswan thenswan self-assigned this Nov 27, 2024
@thenswan thenswan added this to the v0.58 milestone Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

Node: Timing Sensitive Unit Test Results

   91 files  ±0      1 errors  90 suites  ±0   30m 50s ⏱️ + 2m 10s
8 219 tests ±0  8 193 ✅ ±0  25 💤 ±0  1 ❌ ±0 
8 909 runs  ±0  8 883 ✅ ±0  25 💤 ±0  1 ❌ ±0 

For more details on these parsing errors and failures, see this check.

Results for commit 9ce256f. ± Comparison against base commit b8f0637.

♻️ This comment has been updated with latest results.

@thenswan thenswan changed the title chore: deep VirtualMap key validation fix: RandomVirtualMapReconnectTests tests fail with deep VirtualMap key validation Dec 2, 2024
@thenswan thenswan changed the title fix: RandomVirtualMapReconnectTests tests fail with deep VirtualMap key validation chore: add deep VirtualMap key validation for reconnect tests Dec 2, 2024
Signed-off-by: Nikita Lebedev <[email protected]>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b8f0637) 97548 63724 65.33%
Head commit (9ce256f) 97548 (+0) 63731 (+7) 65.33% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16824) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.64%. Comparing base (b8f0637) to head (9ce256f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16824   +/-   ##
==========================================
  Coverage      63.63%   63.64%           
- Complexity     20409    20419   +10     
==========================================
  Files           2537     2537           
  Lines          94783    94783           
  Branches        9907     9907           
==========================================
+ Hits           60312    60321    +9     
+ Misses         30869    30862    -7     
+ Partials        3602     3600    -2     

see 6 files with indirect coverage changes

Impacted file tree graph

@thenswan thenswan marked this pull request as ready for review December 2, 2024 15:20
@thenswan thenswan requested review from a team as code owners December 2, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some RandomVirtualMapReconnectTests tests fail with deep VirtualMap key validation
4 participants