Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: System admin exempt from long term schedule throttles #16838

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Nov 29, 2024

Description:

System admin exempt from long term schedule throttles

Related issue(s):
#16737

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ibankov ibankov added this to the v0.57 milestone Nov 29, 2024
@ibankov ibankov self-assigned this Nov 29, 2024
Copy link

codacy-production bot commented Nov 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e874154) 97954 64229 65.57%
Head commit (a3a7e68) 97954 (+0) 64227 (-2) 65.57% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16838) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.90%. Comparing base (e874154) to head (a3a7e68).
Report is 13 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16838      +/-   ##
=============================================
- Coverage      63.91%   63.90%   -0.01%     
  Complexity     20598    20598              
=============================================
  Files           2540     2540              
  Lines          95189    95189              
  Branches        9944     9944              
=============================================
- Hits           60837    60834       -3     
- Misses         30770    30772       +2     
- Partials        3582     3583       +1     

see 1 file with indirect coverage changes

Impacted file tree graph

@ibankov ibankov marked this pull request as ready for review November 29, 2024 09:46
@ibankov ibankov requested review from a team as code owners November 29, 2024 09:46
@ibankov ibankov requested a review from iwsimon November 29, 2024 09:46
vtronkov
vtronkov previously approved these changes Dec 4, 2024
# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/integration/RepeatableHip423Tests.java
vtronkov
vtronkov previously approved these changes Dec 5, 2024
# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/integration/RepeatableHip423Tests.java
@ibankov ibankov merged commit 1af6fc2 into develop Dec 6, 2024
45 checks passed
@ibankov ibankov deleted the hip-423-throttle-positive branch December 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants