Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adapt StatsSigningTestingTool to work with Bytes wrapper for transactions #17144

Merged

Conversation

IvanKavaldzhiev
Copy link
Collaborator

Description:
This PR updates StatsSigningTestingTool to work with the new Bytes format of system transactions.

Related issue(s):

Fixes #16871

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

mustafauzunn and others added 7 commits December 19, 2024 20:52
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ransactions' into 16871-adapt-StatsSigningTestingTool-to-work-with-Bytes

# Conflicts:
#	platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java

Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ransactions' into 16871-adapt-StatsSigningTestingTool-to-work-with-Bytes
@IvanKavaldzhiev IvanKavaldzhiev added the Platform Tickets pertaining to the platform label Dec 20, 2024
@IvanKavaldzhiev IvanKavaldzhiev added this to the v0.58 milestone Dec 20, 2024
@IvanKavaldzhiev IvanKavaldzhiev self-assigned this Dec 20, 2024
@IvanKavaldzhiev IvanKavaldzhiev requested review from a team as code owners December 20, 2024 11:30
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 71.79487% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.95%. Comparing base (307b469) to head (3a1cead).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...emo/stats/signing/StatsSigningTestingToolMain.java 60.00% 4 Missing ⚠️
...igning/StatsSigningTestingToolStateLifecycles.java 83.33% 3 Missing and 1 partial ⚠️
...swirlds/demo/stats/signing/SttTransactionPool.java 0.00% 2 Missing ⚠️
...m/swirlds/demo/stats/signing/TransactionCodec.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17144      +/-   ##
============================================
+ Coverage     67.76%   67.95%   +0.18%     
- Complexity    22281    22344      +63     
============================================
  Files          2606     2606              
  Lines         96872    96901      +29     
  Branches      10094    10098       +4     
============================================
+ Hits          65643    65845     +202     
+ Misses        27483    27295     -188     
- Partials       3746     3761      +15     
Files with missing lines Coverage Δ
...m/swirlds/demo/stats/signing/TransactionCodec.java 34.56% <66.66%> (+34.56%) ⬆️
...swirlds/demo/stats/signing/SttTransactionPool.java 1.53% <0.00%> (+1.53%) ⬆️
...emo/stats/signing/StatsSigningTestingToolMain.java 30.70% <60.00%> (+30.70%) ⬆️
...igning/StatsSigningTestingToolStateLifecycles.java 49.36% <83.33%> (+49.36%) ⬆️

... and 6 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Dec 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.20% (target: -1.00%) 76.92%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (307b469) 96655 69237 71.63%
Head commit (3a1cead) 96684 (+29) 69454 (+217) 71.84% (+0.20%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17144) 39 30 76.92%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Base automatically changed from 16703-refactor-consumer-system-transactions to develop December 20, 2024 12:58
…igningTestingTool-to-work-with-Bytes

# Conflicts:
#	platform-sdk/platform-apps/demos/CryptocurrencyDemo/src/main/java/com/swirlds/demo/crypto/CryptocurrencyDemoState.java
#	platform-sdk/platform-apps/demos/HelloSwirldDemo/src/main/java/com/swirlds/demo/hello/HelloSwirldDemoState.java
#	platform-sdk/platform-apps/demos/StatsDemo/src/main/java/com/swirlds/demo/stats/StatsDemoState.java
#	platform-sdk/platform-apps/tests/AddressBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java
#	platform-sdk/platform-apps/tests/ConsistencyTestingTool/src/main/java/com/swirlds/demo/consistency/ConsistencyTestingToolState.java
#	platform-sdk/platform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java
#	platform-sdk/platform-apps/tests/MigrationTestingTool/src/main/java/com/swirlds/demo/migration/MigrationTestingToolState.java
#	platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PlatformTestingToolState.java
#	platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java
#	platform-sdk/platform-apps/tests/StressTestingTool/src/main/java/com/swirlds/demo/stress/StressTestingToolState.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/PlatformMerkleStateRoot.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldState.java
#	platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleTestingToolState.java
#	platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/state/BlockingSwirldState.java

Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
andrewb1269hg
andrewb1269hg previously approved these changes Dec 26, 2024
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed file platform-sdk/platform-apps/tests/StatsSigningTestingTool/build.gradle.kts and approved.

…ingTestingTool-to-work-with-Bytes

# Conflicts:
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldMain.java

Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
lpetrovic05
lpetrovic05 previously approved these changes Jan 14, 2025
andrewb1269hg
andrewb1269hg previously approved these changes Jan 14, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve file platform-sdk/platform-apps/tests/StatsSigningTestingTool/build.gradle.kts

…ingTestingTool-to-work-with-Bytes

# Conflicts:
#	platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolMain.java
#	platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java

Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to platform-sdk/platform-apps/tests/StatsSigningTestingTool/build.gradle.kts

@IvanKavaldzhiev IvanKavaldzhiev merged commit 84fb83b into main Jan 15, 2025
51 of 52 checks passed
@IvanKavaldzhiev IvanKavaldzhiev deleted the 16871-adapt-StatsSigningTestingTool-to-work-with-Bytes branch January 15, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt StatsSigningTestingTool to work with the new Bytes transaction type and add README.md
7 participants