-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adapt StatsSigningTestingTool to work with Bytes wrapper for transactions #17144
refactor: adapt StatsSigningTestingTool to work with Bytes wrapper for transactions #17144
Conversation
Signed-off-by: Mustafa Uzun <[email protected]>
…r transactions Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…igningTestingTool-to-work-with-Bytes
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ransactions' into 16871-adapt-StatsSigningTestingTool-to-work-with-Bytes # Conflicts: # platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ransactions' into 16871-adapt-StatsSigningTestingTool-to-work-with-Bytes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17144 +/- ##
============================================
+ Coverage 67.76% 67.95% +0.18%
- Complexity 22281 22344 +63
============================================
Files 2606 2606
Lines 96872 96901 +29
Branches 10094 10098 +4
============================================
+ Hits 65643 65845 +202
+ Misses 27483 27295 -188
- Partials 3746 3761 +15
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
...ingTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolMain.java
Outdated
Show resolved
Hide resolved
...ngTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java
Outdated
Show resolved
Hide resolved
...ngTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java
Outdated
Show resolved
Hide resolved
…igningTestingTool-to-work-with-Bytes # Conflicts: # platform-sdk/platform-apps/demos/CryptocurrencyDemo/src/main/java/com/swirlds/demo/crypto/CryptocurrencyDemoState.java # platform-sdk/platform-apps/demos/HelloSwirldDemo/src/main/java/com/swirlds/demo/hello/HelloSwirldDemoState.java # platform-sdk/platform-apps/demos/StatsDemo/src/main/java/com/swirlds/demo/stats/StatsDemoState.java # platform-sdk/platform-apps/tests/AddressBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java # platform-sdk/platform-apps/tests/ConsistencyTestingTool/src/main/java/com/swirlds/demo/consistency/ConsistencyTestingToolState.java # platform-sdk/platform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java # platform-sdk/platform-apps/tests/MigrationTestingTool/src/main/java/com/swirlds/demo/migration/MigrationTestingToolState.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PlatformTestingToolState.java # platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java # platform-sdk/platform-apps/tests/StressTestingTool/src/main/java/com/swirlds/demo/stress/StressTestingToolState.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/PlatformMerkleStateRoot.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldState.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleTestingToolState.java # platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/state/BlockingSwirldState.java Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
...ngTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed file platform-sdk/platform-apps/tests/StatsSigningTestingTool/build.gradle.kts
and approved.
…ingTestingTool-to-work-with-Bytes
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ation transactions Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ingTestingTool-to-work-with-Bytes # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldMain.java Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
...ingTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolMain.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ingTestingTool-to-work-with-Bytes
...ingTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolMain.java
Outdated
Show resolved
Hide resolved
...ingTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolMain.java
Outdated
Show resolved
Hide resolved
...s/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/TransactionCodec.java
Outdated
Show resolved
Hide resolved
...ngTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java
Outdated
Show resolved
Hide resolved
…ingTestingTool-to-work-with-Bytes
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review and approve file platform-sdk/platform-apps/tests/StatsSigningTestingTool/build.gradle.kts
…ingTestingTool-to-work-with-Bytes # Conflicts: # platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolMain.java # platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
3a1cead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to platform-sdk/platform-apps/tests/StatsSigningTestingTool/build.gradle.kts
Description:
This PR updates StatsSigningTestingTool to work with the new Bytes format of system transactions.
Related issue(s):
Fixes #16871
Notes for reviewer:
Checklist