chore: Cherry pick fixes for update of default branch to main #17200

rbarkerSL · 2025-01-03T15:15:55Z

Description:

Modified hedera-services default branch to point be main instead of develop. This should fix the fallout from that.

Related issue(s):

Fixes #17198

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

…7158) Signed-off-by: Roger Barker <[email protected]> (cherry picked from commit 7911109)

Signed-off-by: Roger Barker <[email protected]> Signed-off-by: Jendrik Johannes <[email protected]> Co-authored-by: Jendrik Johannes <[email protected]> Co-authored-by: Andrew Brandt <[email protected]> (cherry picked from commit fb34679) Signed-off-by: Roger Barker <[email protected]>

**Description**: Add GH_TOKEN env variable in Check Prep XTS Job & Check Integration Job State **Related Issue(s)**: Fixes #17159 Signed-off-by: Roger Barker <[email protected]>

**Description**: Adds missing permission **Related Issue(s)**: Fixes #17159 Signed-off-by: Roger Barker <[email protected]>

Signed-off-by: Roger Barker <[email protected]>

codecov · 2025-01-03T15:48:41Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.33%. Comparing base (ec480dd) to head (a5d36a8).

Files with missing lines	Patch %	Lines
...irlds/platform/cli/JrsTestReaderReportCommand.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##             release/0.58   #17200   +/-   ##
===============================================
  Coverage           64.33%   64.33%           
- Complexity          20910    20911    +1     
===============================================
  Files                2549     2549           
  Lines               95993    95993           
  Branches            10047    10047           
===============================================
+ Hits                61754    61761    +7     
+ Misses              30602    30597    -5     
+ Partials             3637     3635    -2

Files with missing lines	Coverage Δ
.../common/wiring/model/diagram/HyperlinkBuilder.java	`86.66% <ø> (ø)`
...irlds/platform/cli/JrsTestReaderReportCommand.java	`0.00% <0.00%> (ø)`

... and 12 files with indirect coverage changes

thomas-swirlds-labs

LGTM. Thanks! @rbarkerSL

codacy-production · 2025-01-03T15:49:45Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.01% (target: -1.00%)	✅ 0.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`ec480dd`)	95756	65199	68.09%
Head commit (`a5d36a8`)	95756 (+0)	65204 (+5)	68.09% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#17200)	1	0	0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

.github/workflows/zxcron-extended-test-suite.yaml

docs/maintainers-guide.md

docs/branch-naming-conventions.md

rbarkerSL · 2025-01-03T16:51:34Z

I will open a new issue in services to capture these nits so that they feedback into the main branch.

docs/branch-naming-conventions.md rename header to Default Branch
docs/branch-naming-conventions.md add a period at the end of this sentence
docs/maintainers-guide.md remove reference to unnecessary labeling
.github/workflows/zxcron-extended-test-suite.yaml Rename BRANCH_ON_DEVELOP variable to BRANCH_ON_DEFAULT

andrewb1269hg

Looks good!

alex-kuzmin-hg

Reviewed: looks good

…fact-workflow

platform-sdk/docs/proposals/metric-labels/README.md

Signed-off-by: Roger Barker <[email protected]> Signed-off-by: Jendrik Johannes <[email protected]> Co-authored-by: Jendrik Johannes <[email protected]> Co-authored-by: Andrew Brandt <[email protected]> Co-authored-by: Thomas Moran <[email protected]> Signed-off-by: Roger Barker <[email protected]>

#17235) Signed-off-by: Roger Barker <[email protected]> Signed-off-by: Jendrik Johannes <[email protected]> Co-authored-by: Jendrik Johannes <[email protected]> Co-authored-by: Andrew Brandt <[email protected]> Co-authored-by: Thomas Moran <[email protected]>

rbarkerSL and others added 4 commits January 3, 2025 09:08

chore: Update workrflow names to point to main instead of develop (#1…

b5558d8

…7158) Signed-off-by: Roger Barker <[email protected]> (cherry picked from commit 7911109)

ci: Update Check Integration/XTS Job State to include GH_TOKEN

0e22565

**Description**: Add GH_TOKEN env variable in Check Prep XTS Job & Check Integration Job State **Related Issue(s)**: Fixes #17159 Signed-off-by: Roger Barker <[email protected]>

ci: Add id_token write permission to node-flow-deploy-release-artifact

dd4c37b

**Description**: Adds missing permission **Related Issue(s)**: Fixes #17159 Signed-off-by: Roger Barker <[email protected]>

rbarkerSL added Release Issues tied to release management functions. github_actions Pull requests that update GitHub Actions code labels Jan 3, 2025

rbarkerSL added this to the v0.58 milestone Jan 3, 2025

rbarkerSL self-assigned this Jan 3, 2025

Ran spotless apply

0757288

Signed-off-by: Roger Barker <[email protected]>

rbarkerSL marked this pull request as ready for review January 3, 2025 15:46

rbarkerSL requested review from a team as code owners January 3, 2025 15:46

rbarkerSL requested review from andrewb1269hg, timo0, artemananiev, rbair23, povolev15 and jeromy-cannon January 3, 2025 15:46

thomas-swirlds-labs approved these changes Jan 3, 2025

View reviewed changes

kimbor approved these changes Jan 3, 2025

View reviewed changes

.github/workflows/zxcron-extended-test-suite.yaml Show resolved Hide resolved

docs/maintainers-guide.md Show resolved Hide resolved

andrewb1269hg requested changes Jan 3, 2025

View reviewed changes

docs/branch-naming-conventions.md Show resolved Hide resolved

docs/branch-naming-conventions.md Show resolved Hide resolved

rbarkerSL mentioned this pull request Jan 3, 2025

Chore: Clean up variable names and documentation #17201

Open

rbarkerSL requested a review from andrewb1269hg January 3, 2025 17:41

andrewb1269hg approved these changes Jan 3, 2025

View reviewed changes

nathanklick approved these changes Jan 3, 2025

View reviewed changes

imalygin approved these changes Jan 3, 2025

View reviewed changes

alex-kuzmin-hg approved these changes Jan 4, 2025

View reviewed changes

Merge branch 'release/0.58' into 17198-issue-with-deploy-release-arti…

a5d36a8

…fact-workflow

poulok reviewed Jan 6, 2025

View reviewed changes

platform-sdk/docs/proposals/metric-labels/README.md Show resolved Hide resolved

poulok approved these changes Jan 6, 2025

View reviewed changes

poulok merged commit 358bbba into release/0.58 Jan 6, 2025
48 of 50 checks passed

poulok deleted the 17198-issue-with-deploy-release-artifact-workflow branch January 6, 2025 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Cherry pick fixes for update of default branch to main #17200

chore: Cherry pick fixes for update of default branch to main #17200

rbarkerSL commented Jan 3, 2025

codecov bot commented Jan 3, 2025 •

edited

Loading

thomas-swirlds-labs left a comment

codacy-production bot commented Jan 3, 2025 •

edited

Loading

rbarkerSL commented Jan 3, 2025

andrewb1269hg left a comment

alex-kuzmin-hg left a comment

chore: Cherry pick fixes for update of default branch to main #17200

chore: Cherry pick fixes for update of default branch to main #17200

Conversation

rbarkerSL commented Jan 3, 2025

codecov bot commented Jan 3, 2025 • edited Loading

Codecov Report

thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

codacy-production bot commented Jan 3, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

rbarkerSL commented Jan 3, 2025

andrewb1269hg left a comment

Choose a reason for hiding this comment

alex-kuzmin-hg left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 3, 2025 •

edited

Loading

codacy-production bot commented Jan 3, 2025 •

edited

Loading