feat: Adds tests that verify IHRC904 airdropToken targeted to an EOA are functional when called by a contract#1185
Merged
simzzz merged 8 commits intohashgraph:mainfrom Feb 4, 2025
Conversation
…evious PR Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
simzzz
requested review from
a team,
Ivo-Yankov,
georgi-l95,
natanasow and
yiliev0
as code owners
quiet-node
requested changes
Jan 17, 2025
Member
quiet-node
left a comment
quiet-node
left a comment
There was a problem hiding this comment.
Great work! Left some blocking suggestions tho.
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
quiet-node
requested changes
Jan 21, 2025
Member
There was a problem hiding this comment.
Blocking because tests are failing, as HIP-904 will not be enabled until issue #1171 is resolved.
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
quiet-node
reviewed
Jan 29, 2025
quiet-node
reviewed
Jan 30, 2025
quiet-node
previously approved these changes
Feb 3, 2025
Member
quiet-node
left a comment
quiet-node
left a comment
There was a problem hiding this comment.
LGTM! Thans for the great work!
konstantinabl
approved these changes
Feb 4, 2025
konstantinabl
previously approved these changes
Feb 4, 2025
simzzz
force-pushed
the
1109-airdrop-contract-coverage
branch
from
47a08ef to
9b3b14d
Compare
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
simzzz
force-pushed
the
1109-airdrop-contract-coverage
branch
from
9b3b14d to
7e7f8b2
Compare
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
quiet-node
approved these changes
Feb 4, 2025
simzzz
force-pushed
the
1109-airdrop-contract-coverage
branch
2 times, most recently
from
8d23673 to
3c752e9
Compare
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
simzzz
force-pushed
the
1109-airdrop-contract-coverage
branch
from
3c752e9 to
9948fee
Compare
mp-arianelabs
pushed a commit
to Ariane-Labs/hedera-smart-contracts
that referenced
this pull request
Feb 10, 2025
…are functional when called by a contract (hashgraph#1185) * feat: added test coverage of Airdrop.sol with requested fixes from previous PR Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * feat: requested changes for Airdrop tokens test coverage Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * feat: recompiled contract Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * skipped tests temporarily Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * requested changes from PR Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * fix conflicts Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> --------- Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
mp-arianelabs
pushed a commit
to Ariane-Labs/hedera-smart-contracts
that referenced
this pull request
Feb 10, 2025
…are functional when called by a contract (hashgraph#1185) * feat: added test coverage of Airdrop.sol with requested fixes from previous PR Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * feat: requested changes for Airdrop tokens test coverage Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * feat: recompiled contract Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * skipped tests temporarily Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * requested changes from PR Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * fix conflicts Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> --------- Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds tests that verify IHRC904 airdropToken targeted to an EOA are functional when called by a contract, by using the already existing smart contract. This test coverage was in a previous PR and was already reviewed once. Here we separated it from the example contracts so it didn't block the PR and the requested changes, mainly by @quiet-node were addressed.
Related issue(s):
Closes #1109
Notes for reviewer:
One of the tests is currently skipped due to a bug uncovered in the services repo, while testing. The test will fail until the issue is fixed, and a new issue will be created here to remove the skip once the issue in services is resolved.
hiero-ledger/hiero-consensus-node#17409
Checklist