feat: active session management for stale / removed sessions #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Coverage report
Show new covered files 🐣
Test suite run success151 tests passing in 11 suites. Report generated by 🧪jest coverage report action from dd08eef |
Signed-off-by: Michael Kantor <[email protected]>
kantorcodes
changed the title
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
…ent/CON-494 Signed-off-by: Michael Kantor <[email protected]>
itsbrandondev
requested review from
franfernandez20,
teacoat and
valeraOlexienko
…' into fix-session-management/CON-494
justynspooner
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There have been reports that
sessionsno longer exist despite aSignerstill being available. This PR introduces a more active role in the library to automatically detect this kind of a mismatch.Signerwhen itssessionis no longer valid. A session might become invalid either by expiring, by a user disconnecting from the wallet, or some sort of a desync from IndexedDB.test:watchto make it easier to debug tests.Related issue(s):
Fixes #
Notes for reviewer:
Checklist