Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Ordering issue in PBJ Comparable handling #189

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsync-swirlds
Copy link
Member

@jsync-swirlds jsync-swirlds commented Jan 30, 2024

Note: This is not a fix. This is just changes needed to highlight the issue in CI and better describe what is failing. Fixing this issue will likely require a substantial effort.

  • Added messages to test protobufs that fail in CI
  • Adjusted getJavaFile to check existence and provide clearer error messages if a required file is missing
  • Moved a few strings to constants in Common.java
  • Removed a few unnecessary toString calls
  • Fixed wildcard static import in Field.java

Additional minor adjustments

  • Updated the Java language version to 21.
  • Updated github CI config to use Java 21
  • Moved the folder for the protobuf grammar file (Protobuf3.g4) to correct a package mismatch

Copy link

github-actions bot commented Jan 30, 2024

JUnit Test Report

     47 files  ±0       47 suites  ±0   2m 29s ⏱️ -34s
1 116 tests ±0  1 115 ✔️ ±0    1 💤 ±0  0 ±0 
6 971 runs  ±0  6 953 ✔️ ±0  18 💤 ±0  0 ±0 

Results for commit aff86a9. ± Comparison against base commit f6a4abc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

codacy-production bot commented Jan 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.31% (target: -1.00%) 3.92%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f6a4abc) 4263 1901 44.59%
Head commit (aff86a9) 4297 (+34) 1903 (+2) 44.29% (-0.31%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#189) 51 2 3.92%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@jsync-swirlds jsync-swirlds force-pushed the handle-incorrect-camel-case branch 5 times, most recently from bfa8b1a to f2f0559 Compare January 30, 2024 20:58
@jsync-swirlds jsync-swirlds changed the title fix: Fix handling of improper camel case (e.g. TokenID vs TokenId) in proto message names fix: Fix Ordering issue in PBJ Comparable handling Jan 30, 2024
* Added messages to test protobufs that fail in CI
* Adjusted getJavaFile to check existence and provide clearer error messages if a required file is missing
* Moved a few strings to constants in Common.java
* Removed a few unnecessary `toString` calls
* Fixed wildcard static import in Field.java
---
Additional minor adjustments
* Updated the Java language version to 21.
* Updated github CI config to use Java 21
* Moved the folder for the protobuf grammar file (Protobuf3.g4) to correct a package mismatch

Signed-off-by: Joseph Sinclair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant