Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More perf work #21

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Refined benchmarks

b06ad0b
Select commit
Loading
Failed to load commit list.
Draft

More perf work #21

Refined benchmarks
b06ad0b
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Nov 13, 2023 in 0s

74 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 7
- Added 74
           

Complexity increasing per file
==============================
- pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java  3

See the complete overview on Codacy

Annotations

Check warning on line 51 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/ProtoParserTools.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/ProtoParserTools.java#L51 

Avoid reassigning parameters such as 'list'

Check notice on line 228 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/ProtoParserTools.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/ProtoParserTools.java#L228 

Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 227.

Check notice on line 12 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java#L12 

Unused import - java.util.Arrays.

Check notice on line 51 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java#L51 

'VARIABLE_DEF' should be separated from previous line.

Check warning on line 63 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java#L63 

Use equals() to compare object references.

Check warning on line 515 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java#L515 

These nested if statements could be combined

Check notice on line 554 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java#L554 

Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 555.

Check notice on line 559 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java#L559 

Comment has incorrect indentation level 0, expected is 8, indentation should be the same level as line 557.

Check notice on line 587 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java#L587 

Line is longer than 120 characters (found 126).

Check warning on line 815 in pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/io/OffHeapDataBuffer.java#L815 

Avoid reassigning parameters such as 'value'

Check notice on line 17 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L17 

Using the '.*' form of import should be avoided - org.openjdk.jmh.annotations.*.

Check notice on line 40 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L40 

'VARIABLE_DEF' should be separated from previous line.

Check notice on line 42 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L42 

'VARIABLE_DEF' should be separated from previous line.

Check notice on line 48 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L48 

'VARIABLE_DEF' should be separated from previous line.

Check notice on line 56 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L56 

'VARIABLE_DEF' should be separated from previous line.

Check notice on line 57 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L57 

'VARIABLE_DEF' should be separated from previous line.

Check warning on line 96 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L96 

Avoid throwing raw exception types.

Check notice on line 128 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L128 

'METHOD_DEF' should be separated from previous line.

Check notice on line 149 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L149 

Line is longer than 120 characters (found 133).

Check notice on line 156 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L156 

Line is longer than 120 characters (found 127).

Check notice on line 227 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L227 

Line is longer than 120 characters (found 125).

Check notice on line 263 in pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/jmh/java/com/hedera/pbj/intergration/jmh/ProtobufObjectBench.java#L263 

Line is longer than 120 characters (found 130).

Check warning on line 41 in pbj-integration-tests/src/main/java/com/hedera/pbj/integration/EverythingWriterPerfTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/main/java/com/hedera/pbj/integration/EverythingWriterPerfTest.java#L41 

Avoid unused local variables such as 'e'.

Check notice on line 47 in pbj-integration-tests/src/main/java/com/hedera/pbj/integration/EverythingWriterPerfTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/main/java/com/hedera/pbj/integration/EverythingWriterPerfTest.java#L47 

'METHOD_DEF' should be separated from previous line.

Check warning on line 47 in pbj-integration-tests/src/main/java/com/hedera/pbj/integration/EverythingWriterPerfTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

pbj-integration-tests/src/main/java/com/hedera/pbj/integration/EverythingWriterPerfTest.java#L47 

Avoid unused private methods such as 'parseProtoC()'.
View more details on Codacy Production