-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide a mechanism for server streaming applications to register a callback #320
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
JUnit Test Report 67 files +1 67 suites +1 3m 2s ⏱️ +34s Results for commit ea87a87. ± Comparison against base commit 44991ec. This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Matt Peterson <[email protected]>
Integration Test Report 297 files +1 297 suites +1 8m 50s ⏱️ + 1m 39s Results for commit ea87a87. ± Comparison against base commit 44991ec. This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed pbj-core/pbj-grpc-helidon/build.gradle.kts
and looks good.
Description:
registerOnErrorHandler
to thePipeline
interfaceonError()
method which fixes Helidon exceptions are not propagated up through PbjProtocolHandler to the application viaonError
#304Related issue(s):
Fixes #303, #304
Notes for reviewer:
Checklist