Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide a mechanism for server streaming applications to register a callback #320

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mattp-swirldslabs
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs commented Nov 11, 2024

Description:

Related issue(s):

Fixes #303, #304

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mattp-swirldslabs mattp-swirldslabs self-assigned this Nov 11, 2024
Copy link

github-actions bot commented Nov 11, 2024

JUnit Test Report

   67 files  +1     67 suites  +1   3m 2s ⏱️ +34s
1 245 tests +1  1 242 ✅ +1   3 💤 ±0  0 ❌ ±0 
7 100 runs  +1  7 081 ✅ +1  19 💤 ±0  0 ❌ ±0 

Results for commit ea87a87. ± Comparison against base commit 44991ec.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.
, 1
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] FLOAT, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c311be0@38929da, [0.1, 0.5, 100.0], 12, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c311df8@69d667a5
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] STRING, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c31ecf0@c67395, [string 1, testing here, testing there], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c31ef08@5fc7255c
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] BYTES, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c31f120@61993d18, [010203, ff7f0f, 42da07370bff], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c31f338@6f240187
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] DOUBLE, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312010@95cecc5, [0.1, 0.5, 100.0, 1.7653472635472653E240], 32, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312228@48b3b1b8
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [3] BOOL, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312440@b86cb18, [true, false, false, true, true, true], 6, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312658@29c244e
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [4] ENUM, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312870@6cc8da1c, [Mock for EnumWithProtoMetadata, hashCode: 859156431, Mock for EnumWithProtoMetadata, hashCode: 1523941008, Mock for EnumWithProtoMetadata, hashCode: 439636632], 3, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f218c312a88@574ebdaf
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
com.hedera.pbj.grpc.helidon.PbjProtocolHandlerTest ‑ testOnErrorHandlerCalledOnException()
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] FLOAT, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c311be0@377e573a, [0.1, 0.5, 100.0], 12, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c311df8@76db9048
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] STRING, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c31ecf0@3a70575, [string 1, testing here, testing there], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c31ef08@5d96d434
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] BYTES, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c31f120@210635fd, [010203, ff7f0f, 42da07370bff], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c31f338@63814bbe
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] DOUBLE, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c312010@308a9264, [0.1, 0.5, 100.0, 1.7653472635472653E240], 32, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c312228@7da77305
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [3] BOOL, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c312440@3cdfbbef, [true, false, false, true, true, true], 6, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c312658@7a1ddbf1
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [4] ENUM, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c312870@1e606f64, [Mock for EnumWithProtoMetadata, hashCode: 856901180, Mock for EnumWithProtoMetadata, hashCode: 2112194333, Mock for EnumWithProtoMetadata, hashCode: 1238642607], 3, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007ff50c312a88@605eb072
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
, 1

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 11, 2024

Integration Test Report

    297 files  +1      297 suites  +1   8m 50s ⏱️ + 1m 39s
104 157 tests +4  104 157 ✅ +4  0 💤 ±0  0 ❌ ±0 
104 385 runs  +4  104 385 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit ea87a87. ± Comparison against base commit 44991ec.

This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both.
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [1] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f42a050fd90@3aea9ef3
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [2] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f42a050d000@23247fdf
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [3] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f42a050d238@a05c95f
com.hedera.hapi.node.state.schedule.tests.ScheduleIdListTest ‑ [1] NoToStringWrapper{com.hedera.hapi.node.state.schedule.ScheduleIdList}
com.hedera.hapi.node.state.schedule.tests.ScheduleIdListTest ‑ [2] NoToStringWrapper{com.hedera.hapi.node.state.schedule.ScheduleIdList}
com.hedera.hapi.node.state.schedule.tests.ScheduleIdListTest ‑ [3] NoToStringWrapper{com.hedera.hapi.node.state.schedule.ScheduleIdList}
com.hedera.hapi.node.state.schedule.tests.ScheduleIdListTest ‑ testTestEqualsAndHashCode()
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [1] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f47084ed410@759f02a8
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [2] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f47084ed648@1f4de1d6
com.hedera.pbj.intergration.test.ParserNeverWrapsTest ‑ [3] com.hedera.pbj.intergration.test.ParserNeverWrapsTest$$Lambda/0x00007f47084ed880@24ab234a

♻️ This comment has been updated with latest results.

@mattp-swirldslabs mattp-swirldslabs marked this pull request as ready for review November 14, 2024 16:07
@mattp-swirldslabs mattp-swirldslabs changed the title 00303 runnable registration 2 feat: Provide a mechanism for server streaming applications to register a callback Nov 14, 2024
Copy link

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed pbj-core/pbj-grpc-helidon/build.gradle.kts and looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants