Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People API: Convert null result to an empty array #633

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Mar 5, 2024

Adds logic to convert a {results: null} response from Google's People API into an empty array.

This will make the PeopleSelect show a "no results" message instead of logging an error and continuing to show any previously loaded results.

@jeffdaley jeffdaley marked this pull request as ready for review March 5, 2024 21:20
@jeffdaley jeffdaley requested a review from a team as a code owner March 5, 2024 21:20
@jeffdaley jeffdaley merged commit 1d7658d into main Mar 5, 2024
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/handle-null-in-people-select branch March 5, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants