Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding to "Approve" footer #637

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add padding to "Approve" footer #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 36 additions & 34 deletions web/app/components/document/sidebar.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,45 +405,47 @@
{{#if this.footerIsShown}}
<div
data-test-sidebar-footer
class="sidebar-footer {{if this.editingIsDisabled 'locked'}}"
class="sidebar-footer
{{if
this.footerControlsAreDisabled
'border-t border-t-color-border-primary'
}}"
>
{{#if this.footerControlsAreDisabled}}
{{! Disabled controls }}
<div class="-mb-1 px-3">
<div class="w-full border-t border-color-border-primary pt-3.5">
<div class="text-body-200 text-color-foreground-faint">
<h5
data-test-disabled-footer-h5
class="mb-1 flex items-center text-body-200 font-semibold text-color-foreground-primary"
>
{{if this.docIsLocked "Document is locked" "Read-only headers"}}
<FlightIcon
@name="lock"
class="-mt-px ml-1.5 shrink-0 text-color-foreground-faint"
/>
</h5>
<p class="mb-1.5">
{{if
this.docIsLocked
"Due to a Google API bug, all suggestions must be removed from the document header to unlock."
"Weʼre unable to edit the metadata of files created offsite."
}}
</p>
</div>
{{#if this.docIsLocked}}
<Hds::Link::Standalone
@icon="arrow-right"
@iconPosition="trailing"
@text="See the issue on GitHub"
@size="small"
@href="https://github.com/hashicorp-forge/hermes/issues/181"
<div class="-mb-1 -mt-0.5 px-3">
<div class="text-body-200 text-color-foreground-faint">
<h5
data-test-disabled-footer-h5
class="mb-1 flex items-center text-body-200 font-semibold text-color-foreground-primary"
>
{{if this.docIsLocked "Document is locked" "Read-only headers"}}
<FlightIcon
@name="lock"
class="-mt-px ml-1.5 shrink-0 text-color-foreground-faint"
/>
{{else}}
<div class="text-body-100 text-color-foreground-faint">
Create docs in-app for best results.
</div>
{{/if}}
</h5>
<p class="mb-1.5">
{{if
this.docIsLocked
"Due to a Google API bug, all suggestions must be removed from the document header to unlock."
"Weʼre unable to edit the metadata of files created offsite."
}}
</p>
</div>
{{#if this.docIsLocked}}
<Hds::Link::Standalone
@icon="arrow-right"
@iconPosition="trailing"
@text="See the issue on GitHub"
@size="small"
@href="https://github.com/hashicorp-forge/hermes/issues/181"
/>
{{else}}
<div class="text-body-100 text-color-foreground-faint">
Create docs in-app for best results.
</div>
{{/if}}
</div>
{{else}}
{{#let (and this.isDraft this.isOwner) as |canPublish|}}
Expand Down
4 changes: 0 additions & 4 deletions web/app/styles/components/sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,5 @@

.sidebar-footer {
@apply w-full shrink-0 bg-color-page-faint py-4 px-3.5;

&.locked {
@apply pt-0;
}
}
}
Loading