CSL-10969: Add new output format archive to proxy list command
#4785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: `proxy list -output archive` cmd will write output to json file
LordAbhishek
added
area/cli
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
LordAbhishek
changed the title
archive to proxy list cmdarchive to proxy list command
LordAbhishek
changed the title
archive to proxy list commandarchive to proxy list command
cli/cmd/proxy/list/command.go
Outdated
| if errs := validation.ValidateNamespaceName(c.flagNamespace, false); c.flagNamespace != "" && len(errs) > 0 { | ||
| return fmt.Errorf("invalid namespace name passed for -namespace/-n: %v", strings.Join(errs, "; ")) | ||
| } | ||
| if outputs := []string{"table", "json", "archive"}; !slices.Contains(outputs, c.flagOutputFormat) { |
cli/cmd/proxy/list/command.go
Outdated
| } else { | ||
| c.UI.Output(string(jsonSt)) | ||
| } | ||
| } else if c.flagOutputFormat == "archive" { |
There was a problem hiding this comment.
could we have used switch case and make the internal modular. Makes it legible
sanikachavan5
previously approved these changes
Sep 25, 2025
sanikachavan5
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
archiveto the proxy list command. This will write the proxy list command json output to a json file in current working dir.consul-k8s proxy list -output archive