catalog: add failover mode enum validation (#18545)

hashicorp · Aug 22, 2023 · 570c84d · 570c84d
1 parent c4b3234
commit 570c84d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/internal/catalog/internal/types/failover_policy.go b/internal/catalog/internal/types/failover_policy.go
@@ -139,6 +139,18 @@ func validateFailoverConfig(config *pbcatalog.FailoverConfig, ported bool) []err
 		}
 	}
 
+	switch config.Mode {
+	case pbcatalog.FailoverMode_FAILOVER_MODE_UNSPECIFIED:
+		// means pbcatalog.FailoverMode_FAILOVER_MODE_SEQUENTIAL
+	case pbcatalog.FailoverMode_FAILOVER_MODE_SEQUENTIAL:
+	case pbcatalog.FailoverMode_FAILOVER_MODE_ORDER_BY_LOCALITY:
+	default:
+		errs = append(errs, resource.ErrInvalidField{
+			Name:    "mode",
+			Wrapped: fmt.Errorf("not a supported enum value: %v", config.Mode),
+		})
+	}
+
 	// TODO: validate sameness group requirements
 
 	return errs

diff --git a/internal/catalog/internal/types/failover_policy_test.go b/internal/catalog/internal/types/failover_policy_test.go
@@ -200,6 +200,15 @@ func TestValidateFailoverPolicy(t *testing.T) {
 				SamenessGroup: "blah",
 			},
 		},
+		"mode: invalid": {
+			config: &pbcatalog.FailoverConfig{
+				Mode: 99,
+				Destinations: []*pbcatalog.FailoverDestination{
+					{Ref: newRef(ServiceType, "api-backup")},
+				},
+			},
+			expectErr: `invalid "mode" field: not a supported enum value: 99`,
+		},
 		"dest: no ref": {
 			config: &pbcatalog.FailoverConfig{
 				Destinations: []*pbcatalog.FailoverDestination{