Skip to content

Commit

Permalink
simplify wal defaulting logic, fix docs
Browse files Browse the repository at this point in the history
  • Loading branch information
dhiaayachi committed Sep 16, 2024
1 parent 5b59260 commit 82225d4
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 8 deletions.
19 changes: 12 additions & 7 deletions agent/consul/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -1055,18 +1055,23 @@ func (s *Server) setupRaft() error {
stable = wal
return nil
}
// Only use WAL if there is no existing raft.db, even if it's enabled.
if (s.config.LogStoreConfig.Backend == LogStoreBackendDefault || s.config.LogStoreConfig.Backend == LogStoreBackendWAL) && !boltFileExists {

// Default to WAL if there is no existing raft.db, even if it's enabled. Log a warning otherwise
if s.config.LogStoreConfig.Backend == LogStoreBackendDefault && !boltFileExists {
s.config.LogStoreConfig.Backend = LogStoreBackendWAL
} else if s.config.LogStoreConfig.Backend == LogStoreBackendWAL || s.config.LogStoreConfig.Backend == LogStoreBackendDefault {
// User configured the new storage, but still has old raft.db. Warn
// them!
s.logger.Warn("BoltDB file raft.db found, IGNORING raft_logstore.backend which is set to 'wal'")
}

if s.config.LogStoreConfig.Backend == LogStoreBackendWAL && !boltFileExists {
s.config.LogStoreConfig.Backend = LogStoreBackendWAL
if err = initWAL(); err != nil {
return err
}
} else {
if s.config.LogStoreConfig.Backend == LogStoreBackendWAL || s.config.LogStoreConfig.Backend == LogStoreBackendDefault {
// User configured the new storage, but still has old raft.db. Warn
// them!
s.logger.Warn("BoltDB file raft.db found, IGNORING raft_logstore.backend which is set to 'wal'")
}

s.config.LogStoreConfig.Backend = LogStoreBackendBoltDB
// Create the backend raft store for logs and stable storage.
store, err := raftboltdb.New(raftboltdb.Options{
Expand Down
2 changes: 1 addition & 1 deletion website/content/docs/agent/wal-logstore/enable.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ description: >-

# Enable the WAL LogStore backend

WAL LogStore is now enabled by default
WAL LogStore is now enabled by default unless a BoltDB database already exist.

## Known issues

Expand Down

0 comments on commit 82225d4

Please sign in to comment.