Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Upgrade d3 packages to update color dependency #21588

Merged
merged 4 commits into from
Aug 12, 2024
Merged

ui: Upgrade d3 packages to update color dependency #21588

merged 4 commits into from
Aug 12, 2024

Conversation

sarahalsmiller
Copy link
Member

Description

Update D3 packages to resolve DoS issue

Testing & Reproduction steps

  • CI Passes and UI deployment looks as expected

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@sarahalsmiller sarahalsmiller added the backport/all Apply backports for all active releases per .release/versions.hcl label Aug 5, 2024
@github-actions github-actions bot added the theme/ui Anything related to the UI label Aug 5, 2024
@sarahalsmiller sarahalsmiller changed the title Upgrade d3 packages to update color dependency ui: Upgrade d3 packages to update color dependency Aug 5, 2024
@sarahalsmiller sarahalsmiller marked this pull request as ready for review August 6, 2024 15:07
@philrenaud philrenaud self-requested a review August 9, 2024 17:42
@philrenaud philrenaud merged commit 929d602 into main Aug 12, 2024
70 checks passed
@philrenaud philrenaud deleted the NET-8717-Vulnerabilities-in-consul-enterprise-d3-color branch August 12, 2024 13:52
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Aug 12, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Aug 12, 2024
Closed
4 tasks
philrenaud added a commit that referenced this pull request Aug 12, 2024
@sarahalsmiller @philrenaud
ui: Upgrade d3 packages to update color dependency (#21588)
d0f2e85 
* upgrade d3 packages to update color dependency

* yarn package bump

* deps moved into devdeps

---------

Co-authored-by: Phil Renaud <[email protected]>
@philrenaud philrenaud mentioned this pull request Aug 12, 2024
Merged
philrenaud added a commit that referenced this pull request Aug 12, 2024
@sarahalsmiller @philrenaud
ui: Upgrade d3 packages to update color dependency (#21588)
a7b7fd3 
* upgrade d3 packages to update color dependency

* yarn package bump

* deps moved into devdeps

---------

Co-authored-by: Phil Renaud <[email protected]>
philrenaud added a commit that referenced this pull request Aug 12, 2024
@philrenaud @sarahalsmiller
Backport of ui: Upgrade d3 packages to update color dependency into r…
c2c8aeb 
…elease/1.19.x (#21597)

ui: Upgrade d3 packages to update color dependency (#21588)

* upgrade d3 packages to update color dependency

* yarn package bump

* deps moved into devdeps

---------

Co-authored-by: sarahalsmiller <[email protected]>
@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@philrenaud
Copy link
Collaborator

Backports in fact were merged yesterday:

1.19
1.15

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@jmurret
Copy link
Member

jmurret commented Aug 14, 2024

hey @philrenaud for manual backports you need to add the list of commits so backport-assistant picks them up. You will need to add this:

---

<details>


 

 <summary> Overview of unprocessed commits </summary>

 
 * [e1350c9e2ef2b6436dfca01276da827e175da283](https://github.com/hashicorp/consul/commit/e1350c9e2ef2b6436dfca01276da827e175da283)
 
 * [b3a423b7663549372cd4766092cfa921d6614b53](https://github.com/hashicorp/consul/commit/b3a423b7663549372cd4766092cfa921d6614b53)
 
 * [04d2887ed42b3a59b0101f9712caee30c422cb83](https://github.com/hashicorp/consul/commit/04d2887ed42b3a59b0101f9712caee30c422cb83)
 
 * [e12eff0cc2e43dfe769ab97532cd3577b5bbbc0a](https://github.com/hashicorp/consul/commit/e12eff0cc2e43dfe769ab97532cd3577b5bbbc0a)
 
</details>

which are the commits specific this change as it relates to PR comments like this

I've copied these from one of the PRs that backport-assistant auto generated when this was merged.

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

4 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

8 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@sarahalsmiller, a backport is missing for this PR [21588] for versions [1.15,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@zalimeni
Copy link
Member

@philrenaud should this have also been backported to Ent 1.18 and 1.17? I think the warnings are off, but the labels that were added don't seem to match the merged PRs and changelog @jmurret just generated for 1.18

@philrenaud
Copy link
Collaborator

@zalimeni yes, I think this probably should also have been backported. Seems like there was a failed cherry-pick in both backports. I'll give it a look shortly

@philrenaud
Copy link
Collaborator

Oops! I see that you'd already resolved those. Approved both!

@zalimeni
Copy link
Member

Oops! I see that you'd already resolved those. Approved both!

Yeah @jmurret was quick - thank you for the look!

philrenaud added a commit that referenced this pull request Sep 12, 2024
@sarahalsmiller @philrenaud
ui: Upgrade d3 packages to update color dependency (#21588)
5e8511e 
* upgrade d3 packages to update color dependency

* yarn package bump

* deps moved into devdeps

---------

Co-authored-by: Phil Renaud <[email protected]>
philrenaud added a commit that referenced this pull request Sep 16, 2024
@philrenaud
Manual backport of #21588 to 1.15.x
db8660a
This was referenced Sep 25, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrenaud philrenaud philrenaud approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sarahalsmiller @hc-github-team-consul-core @philrenaud @jmurret @zalimeni