Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [NET-10719] Fix cluster generation for jwt clusters for external jwt providers into release/1.19.x #21605

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #21604 to be assessed for backporting due to the inclusion of the label backport/1.19.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jm96441n
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "373ac54c9598a3b3de80837307305ba5d2432040", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

JWT clusters were previously not being created correctly, this adds the plumbing to handle this in the enterprise fork

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Aug 14, 2024
@jm96441n jm96441n marked this pull request as ready for review August 14, 2024 20:04
@jm96441n jm96441n requested a review from a team as a code owner August 14, 2024 20:04
@jm96441n jm96441n merged commit 3e4a572 into release/1.19.x Aug 14, 2024
102 checks passed
@jm96441n jm96441n deleted the backport/NET-10719-fix-apigw-jwt-cluster-generation/definitely-nice-joey branch August 14, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants