[NET-11154] test: fix Envoy int tests and add container logs #21674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
added
pr/no-changelog
github-actions
bot
added
type/ci
zalimeni
commented
Aug 27, 2024
| - name: Docker build | ||
| run: docker build -t consul:local -f ./build-support/docker/Consul-Dev.dockerfile ./bin | ||
|
|
There was a problem hiding this comment.
This and above matches later nightly files for consistency
Correctly set the the version of Consul built by the `dev-build` job, which is then copied into the Consul dev image used in integration tests. This was causing failures starting sidecar proxies via `consul connect envoy` due to a mismatch between the (incorrect) Consul binary's supported Envoy versions and the (correct) Envoy version under test. Also add debug log uploads to each int test so we can more easily diagnose this sort of failure in the future, as it was entirely hidden in test output.
zalimeni
force-pushed
the
zalimeni/fix-consul-version-nightly-envoy-tests
branch
from
92f0aa2
to
a7f5962
Compare
zalimeni
commented
Aug 27, 2024
| branch-name: "release/1.17.x" | ||
| branch-name: "release/1.18.x" |
There was a problem hiding this comment.
This was causing failures like the following in container logs:
nathancoleman
approved these changes
Aug 30, 2024
|
To call out explicitly as well: I think the best next improvement here would be to convert all of these to a reusable workflow invoked once per nightly workflow. That said, I wanted to keep scope tight for this change. Hopefully we can follow up on that soon. |
Thanks @nathancoleman and np! |
philrenaud
pushed a commit
that referenced
this pull request
Sep 12, 2024
Correctly set the the version of Consul built by the `dev-build` job, which is then copied into the Consul dev image used in integration tests. This was causing failures starting sidecar proxies via `consul connect envoy` due to a mismatch between the (incorrect) Consul binary's supported Envoy versions and the (correct) Envoy version under test. Also add debug log uploads to each int test so we can more easily diagnose this sort of failure in the future, as it was entirely hidden in test output.
zalimeni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly set the the version of Consul built by the
dev-buildjob, which is then copied into the Consul dev image used in integration tests.This was causing failures starting sidecar proxies via
consul connect envoydue to a mismatch between the (incorrect) Consul binary's supported Envoy versions and the (correct) Envoy version under test.Also add debug log uploads to each int test so we can more easily diagnose this sort of failure in the future, as it was entirely hidden in test output.
What's most unintuitive about this, is that the Consul Docker image used as a base for the tests was correct - it was only the replaced binary in that image that was wrong.
This change does not need to be backported since it's made within scheduled workflows run from
main. Note that only 1.19 tests run on CE; the rest will exclusively affect Ent.PR Checklist