Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Prettify ember-cli-build #21731

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[ui] Prettify ember-cli-build #21731

merged 2 commits into from
Sep 13, 2024

Conversation

philrenaud
Copy link
Collaborator

(JS formatting)

@philrenaud philrenaud self-assigned this Sep 13, 2024
@philrenaud philrenaud added the backport/all Apply backports for all active releases per .release/versions.hcl label Sep 13, 2024
@github-actions github-actions bot added the theme/ui Anything related to the UI label Sep 13, 2024
@philrenaud philrenaud added the pr/no-changelog PR does not need a corresponding .changelog entry label Sep 13, 2024
zalimeni
zalimeni approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@philrenaud philrenaud merged commit 4efac49 into main Sep 13, 2024
72 checks passed
@philrenaud philrenaud deleted the b-ui/prettify-ember-cli-build branch September 13, 2024 19:30
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 13, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Sep 13, 2024
Merged
philrenaud added a commit that referenced this pull request Sep 13, 2024
@philrenaud
[ui] Prettify ember-cli-build (#21731)
bce32af 
* Missed prettification at a pre-merge step earlier

* Missed lint-removal
philrenaud added a commit that referenced this pull request Sep 13, 2024
@philrenaud
[ui] Prettify ember-cli-build (#21731)
d839e33 
* Missed prettification at a pre-merge step earlier

* Missed lint-removal
philrenaud added a commit that referenced this pull request Sep 13, 2024
@hc-github-team-consul-core @philrenaud
Backport of [ui] Prettify ember-cli-build into release/1.19.x (#21733)
4203ba6 
[ui] Prettify ember-cli-build (#21731)

* Missed prettification at a pre-merge step earlier

* Missed lint-removal

Co-authored-by: Phil Renaud <[email protected]>
@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

Assignees

@philrenaud philrenaud

Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 pr/no-changelog PR does not need a corresponding .changelog entry theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philrenaud @zalimeni @hc-github-team-consul-core