Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update security-scan.hcl #21739

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Update security-scan.hcl #21739

merged 2 commits into from
Sep 16, 2024

Conversation

sarahalsmiller
Copy link
Member

Description

Prepare job is still failing despite suppression, attempting to add a line with the updated version

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@sarahalsmiller sarahalsmiller requested a review from a team as a code owner September 16, 2024 17:05
@sarahalsmiller sarahalsmiller added backport/all Apply backports for all active releases per .release/versions.hcl pr/no-changelog PR does not need a corresponding .changelog entry labels Sep 16, 2024
jm96441n
jm96441n approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@jm96441n jm96441n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sarahalsmiller sarahalsmiller enabled auto-merge (squash) September 16, 2024 17:14
zalimeni
zalimeni reviewed Sep 16, 2024
View reviewed changes
.release/security-scan.hcl
@@ -79,7 +79,8 @@ binary {
suppress {
# N.b. `vulnerabilites` is the correct spelling for this tool.
vulnerabilites = [
"CVE-2024-8096", # [email protected]
"CVE-2024-8096", # [email protected],
"CVE-2024-8096", # [email protected],
Copy link
Member

@zalimeni zalimeni Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is just informational for us to keep track of why we skipped the CVE - AFAIK it has no functional effect on scans. We might need to dig deeper into why scans are still failing 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have it only in one line since they are both for the same CVE?

"CVE-2024-8096", # [email protected], [email protected]

@sarahalsmiller sarahalsmiller merged commit 5a84cd1 into main Sep 16, 2024
94 checks passed
@sarahalsmiller sarahalsmiller deleted the Suppress-CVE-2024-8096 branch September 16, 2024 17:42
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 16, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Sep 16, 2024
Closed
4 tasks
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@jmurret jmurret added backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent and removed backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent labels Sep 18, 2024
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

6 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
4 tasks
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

10 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21739] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@nathancoleman nathancoleman added backport/all Apply backports for all active releases per .release/versions.hcl and removed backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/all Apply backports for all active releases per .release/versions.hcl backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.18 Changes are backported to 1.18 ent labels Oct 14, 2024
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/1.20 Changes are backported to 1.20 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Oct 14, 2024
This was referenced Oct 14, 2024
Draft
Closed
@sarahalsmiller sarahalsmiller removed backport/1.20 Changes are backported to 1.20 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.18 Changes are backported to 1.18 ent labels Oct 14, 2024
@nathancoleman nathancoleman removed the backport/all Apply backports for all active releases per .release/versions.hcl label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduzgun-security dduzgun-security dduzgun-security left review comments

@zalimeni zalimeni zalimeni left review comments

@jm96441n jm96441n jm96441n approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sarahalsmiller @hc-github-team-consul-core @zalimeni @jm96441n @dduzgun-security @jmurret @nathancoleman