Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of fix spacing of bash scripts into release/1.19.x #21768

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Backport of fix spacing of bash scripts into release/1.19.x #21768

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e673e2
backport of commit 1e97297215f985e153dd4e92c4444acebbfce0db
jm96441n Sep 17, 2024
5e38f9e
backport of commit b7053f53617fec902a7bf07ebb3b8077334a5cdb
jm96441n Sep 17, 2024
d038751
backport of commit a391f2fa3ce1eb250e5c10546cc1459b5649e587
jm96441n Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions build-support/scripts/gen-changelog.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,28 @@ set -eo pipefail

pr_number=$(gh pr list -H "$(git rev-parse --abbrev-ref HEAD)" -q ".[0].number" --json "number")

if [ -z "$pr_number" ]; then
echo "Error: Could not find PR number."
exit 1
fi

# check if this changelog is referencing an enterprise change
curdir=$(pwd)

filename = ".changelog/$pr_number.txt"
filename=".changelog/$pr_number.txt"
if [[ ! $curdir == *"enterprise"* ]]; then
is_enterprise = "n"
read -p "Is this an enterprise PR? (y/n): " is_enterprise
is_enterprise="n"
read -rp "Is this an enterprise PR? (y/n): " is_enterprise

if [[ $is_enterprise == "y" ]]; then
filename = ".changelog/_$pr_number.txt"
filename=".changelog/_$pr_number.txt"
fi
else
filename = ".changelog/_$pr_number.txt"
filename=".changelog/_$pr_number.txt"
fi

# create a new changelog file
touch $filename
touch "$filename"

echo "Created a new changelog file for PR $pr_number."

Expand All @@ -35,7 +40,7 @@ echo "4. deprecation"
echo "5. bug"

if [ -z "$1" ]; then
read -p "Enter your choice: " choice
read -rp "Enter your choice: " choice
else
choice=$1
fi
Expand Down Expand Up @@ -66,8 +71,10 @@ esac

msg=""

read -ep $'Please enter the changelog message:\n' msg
read -erp $'Please enter the changelog message:\n' msg

echo -e "\`\`\`release-note:$type\n$msg\n\`\`\`" >>"$filename"

cat .changelog/$pr_number.txt
echo -e "\nChangelog added to $filename. Contents:\n"

cat "$filename"
Loading