-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: remove dependency on proto-public, protobuf, and grpc #21780
Conversation
24d083d
to
dce24bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thank you!
Oh wow, this is excellent and will have a big impact on releases. Thank you! |
Thanks everyone. I was trying to pull in the client lib last week and was running into dep issues due to this and it will be great to get it fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
The api submodule has a test-only dependency on
proto-public
. This has the unfortunate side effect of making anybody importingapi
navigate the dependency maze that is protobuf + grpc for no reason.This PR removes the need from the dependency.