api: remove dependency on proto-public, protobuf, and grpc #21780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
force-pushed
the
rboyer/remove-proto-dep-from-api
branch
from
24d083d
to
dce24bf
Compare
|
Oh wow, this is excellent and will have a big impact on releases. Thank you! |
zalimeni
approved these changes
Sep 20, 2024
mkeeler
approved these changes
Sep 23, 2024
|
Thanks everyone. I was trying to pull in the client lib last week and was running into dep issues due to this and it will be great to get it fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The api submodule has a test-only dependency on
proto-public. This has the unfortunate side effect of making anybody importingapinavigate the dependency maze that is protobuf + grpc for no reason.This PR removes the need from the dependency.