Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: remove dependency on proto-public, protobuf, and grpc #21780

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Sep 20, 2024

Description

The api submodule has a test-only dependency on proto-public. This has the unfortunate side effect of making anybody importing api navigate the dependency maze that is protobuf + grpc for no reason.

This PR removes the need from the dependency.

@rboyer rboyer self-assigned this Sep 20, 2024
@github-actions github-actions bot added the theme/api Relating to the HTTP API interface label Sep 20, 2024
@rboyer rboyer force-pushed the rboyer/remove-proto-dep-from-api branch from 24d083d to dce24bf Compare September 20, 2024 21:57
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@zalimeni
Copy link
Member

Oh wow, this is excellent and will have a big impact on releases. Thank you!

@mkeeler
Copy link
Member

mkeeler commented Sep 23, 2024

Thanks everyone. I was trying to pull in the client lib last week and was running into dep issues due to this and it will be great to get it fixed

Copy link
Collaborator

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.20 Changes are backported to 1.20 pr/no-backport pr/no-metrics-test theme/api Relating to the HTTP API interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants