Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unintentionally committed consul-k8s submodule #21833

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

zalimeni
Copy link
Member

Also prevent future re-commits of this submodule path by adding to .gitignore.

Description

Removes submodule added in #21802.

Also prevent future re-commits of this submodule path by adding to
.gitignore.
@zalimeni zalimeni added pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry labels Oct 16, 2024
@zalimeni
Copy link
Member Author

Waiting to merge this so we can make sure the 1.20.x backport of the original (failed, needs recreation manually) doesn't bring in the submodule - if it does, this PR will need backporting too.

@zalimeni
Copy link
Member Author

Fixed in #21835 for 1.20.x so merging now

@zalimeni zalimeni enabled auto-merge (squash) October 16, 2024 14:34
@zalimeni zalimeni merged commit 3370f6b into main Oct 16, 2024
111 of 114 checks passed
@zalimeni zalimeni deleted the remove-k8s-submodule branch October 16, 2024 14:36
missylbytes pushed a commit that referenced this pull request Oct 29, 2024
Also prevent future re-commits of this submodule path by adding to
.gitignore.
missylbytes pushed a commit that referenced this pull request Oct 30, 2024
Also prevent future re-commits of this submodule path by adding to
.gitignore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants